Re: [alsa-devel] [PATCH v8 0/9] adapt SOF to use snd-hda-codec-hdmi

[Takashi Iwai <tiwai@suse.de>]

On Tue, 29 Oct 2019 14:40:08 +0100,
Kai Vehmanen wrote:
> 
> Hey,
> here's the 8th round for this series that adapts SOF to use
> snd-hda-codec-hdmi (patch_hdmi.c) codec driver instead of hdac_hdmi
> (soc/codecs/hdac_hdmi.c). The primary goal is to unify the HDMI codec
> implementation between DSP and non-DSP HDA configurations, offer same
> interface to user-space and reduce maintenance load for all.
> 
> Intended to go in via Mark's ASoC tree.
> 
> v8 changes:
> - rebased on top of Mark's for-next (50484b6a523a)
> - addressed Takashi's review comment to patch 5
> - addressed two sparse warnings in patch 3 reported by
>   kbuild test robot <lkp@intel.com>
> - fixed itnull.cocci warning in patch 3 reported by
>   Julia Lawall <julia.lawall@lip6.fr> and
>   kbuild test robot <lkp@intel.com>
> 
> Feature and testing info:
>  - Tested on multiple Intel platforms supported by SOF.
>  - Tested with ALSA console tools as well as with Pulseaudio.
>       - requires Pulseaudio 12.x or newer, see
>         https://lists.freedesktop.org/archives/pulseaudio-discuss/2019-August/031358.html
>  - HDMI, DP, DP-MST with multi-monitor use-scenarios work ok.
>  - New feature for SOF: ELD /proc fs works just like in
>    DSP-less mode.
>  - New feature for SOF: jack detection works out-of-the-box
>    with Pulseaudio (no need for card specific UCM for HDMI)
> 
> Kai Vehmanen (9):
>   ALSA: hda/hdmi - implement mst_no_extra_pcms flag
>   ASoC: hdac_hda: add support for HDMI/DP as a HDA codec
>   ASoC: Intel: skl-hda-dsp-generic: use snd-hda-codec-hdmi
>   ASoC: Intel: skl-hda-dsp-generic: fix include guard name
>   ASoC: SOF: Intel: add support for snd-hda-codec-hdmi
>   ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support
>   ASoC: Intel: glk_rt5682_max98357a: common hdmi codec support
>   ASoC: intel: sof_rt5682: common hdmi codec support
>   ASoC: Intel: bxt_rt298: common hdmi codec support

Looks good to me.  For the whole series:
  Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel