From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86408C433FF for ; Fri, 9 Aug 2019 05:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6756320C01 for ; Fri, 9 Aug 2019 05:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405576AbfHIFzT (ORCPT ); Fri, 9 Aug 2019 01:55:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:55202 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726792AbfHIFzT (ORCPT ); Fri, 9 Aug 2019 01:55:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 04317AD7F; Fri, 9 Aug 2019 05:55:17 +0000 (UTC) Date: Fri, 09 Aug 2019 07:55:17 +0200 Message-ID: From: Takashi Iwai To: Stephen Rothwell Cc: Mark Brown , Linux Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build failure after merge of the sound tree In-Reply-To: <20190809125458.6c7aaa6c@canb.auug.org.au> References: <20190809125458.6c7aaa6c@canb.auug.org.au> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Aug 2019 04:54:58 +0200, Stephen Rothwell wrote: > > Hi all, > > After merging the sound tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_read': > sound/hda/hdac_bus.c:228:6: error: implicit declaration of function 'readl'; did you mean 'd_real'? [-Werror=implicit-function-declaration] > v = readl(aligned_addr); > ^~~~~ > d_real > sound/hda/hdac_bus.c: In function 'snd_hdac_aligned_write': > sound/hda/hdac_bus.c:244:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] > writel(v, aligned_addr); > ^~~~~~ > > Caused by commit > > 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses") > > I have applied the following patch for today: > > From: Stephen Rothwell > Date: Fri, 9 Aug 2019 12:50:25 +1000 > Subject: [PATCH] ALSA: hda: readl/writel need linux/io.h > > Fixes: 19abfefd4c76 ("ALSA: hda: Direct MMIO accesses") > Signed-off-by: Stephen Rothwell > --- > sound/hda/hdac_bus.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/hda/hdac_bus.c b/sound/hda/hdac_bus.c > index dc2523ef7d98..cd25e2b3f7f2 100644 > --- a/sound/hda/hdac_bus.c > +++ b/sound/hda/hdac_bus.c > @@ -4,6 +4,7 @@ > */ > > #include > +#include > #include > #include > #include Thanks, it's obviously a right fix. I applied it on top of topic/hda-bus-ops-cleanup branch branch. Mark, feel free to pull it into yours again. Takashi