From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx49Ey5hWpr7Hy70tlqTLM2SJy4c6Z0OgFKHkFOjZjpd9zcXtQ6fGbYOoXtYKA9JExpvYaB8+ ARC-Seal: i=1; a=rsa-sha256; t=1524131738; cv=none; d=google.com; s=arc-20160816; b=cj21XTuZsROJ09Tf4a6NgPsxA0pyK1eLVZvqKYEXCnWOB/Zdm0ElZQmeL76YYwn3Ix iL13EbOcy/PHSYYAqgBSEXB8+eq3HZLEJKC7rTlsGTSHxYmKo5HYVA34x/bm4iYnyszw H9/v0rG/sGFJaAJDt51z08Kt7PEW69r43Rv+Yxt9cXHzyJTwbhYoIflfdPDBH4naUwlr FzHZcE0rnAtN2aG0F6Gr09BzNrVA75mypfgXj2R+NENgm5Hzv9ILA8bZqto+VJDG5ynq WxUk+aVjJbp5p6SEUUw+3Fvcvnwa8bZCuOQu0C++6XUrfHH7B5jnq+yrrs0cD77cCylC wjiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:arc-authentication-results; bh=BT7HOUylgkDWcWZ8YjtMcWFX92+a2bCN4sHnFoCpp0U=; b=KiS4wR6M01Rdh4jDcLpfqIJp8ExiPN8f9TLoyOFqB8ZGCOi3oJMeKQr+zcFf90gt8i 2nNHKkwh1KyihwY7ppM3siLUX2gviBR0CqgShYd/mx5lF9FfSznWMs/S1Gi0W5ONLDAc t+MfVTcg4lBdQ0rwsKMwWTHtqWGc4WqwWheNPSQuF/1t+dE8UBJ4eC/nbaMzOpfb3xCk vlemWwvmj7/CILdBD0q5x4itrbPpdgeZtec7eySlef6JuSWh1R+DEzTXVj5RoSCzop2n S9l/r4EYEjTr2jHipcy6DcO7MPegOJrHIq6gJ1o6Wqa5cBmbvQNFZ6+gQ6xXczhrZcgV uAsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Authentication-Results: mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Date: Thu, 19 Apr 2018 11:55:37 +0200 Message-ID: From: Takashi Iwai To: Ruslan Bilovol Cc: Jorge , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing In-Reply-To: <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com> References: <1523658266-2259-1-git-send-email-ruslan.bilovol@gmail.com> <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1597671506346289659?= X-GMAIL-MSGID: =?utf-8?q?1598167961414685219?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Sat, 14 Apr 2018 00:24:23 +0200, Ruslan Bilovol wrote: > > Offload snd_usb_parse_audio_interface() function which > became quite long after adding UAC3 spec support. > > Move class-specific parts to separate functions > which now produce audioformat structure that is > ready to be fed to snd_usb_add_audio_stream(). > > This also broke Blue Microphones workaround (which > relies on audioformat decoded from previous altsetting) > into two parts: prepare quirk flag analyzing previous > altsetting then use it with current altsetting. > > Signed-off-by: Ruslan Bilovol Could you try to split this patch to two parts: one is a simple refactoring to move the code to snd_usb_get_audioformat_uac12(), and another to add snd_usb_get_audioformat_uac3(). In this way, we can see a problem more clearly if it's in the refactoring part. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [alsa-devel] [PATCH 1/4] ALSA: usb: stream: refactor audio interface parsing Date: Thu, 19 Apr 2018 11:55:37 +0200 Message-ID: References: <1523658266-2259-1-git-send-email-ruslan.bilovol@gmail.com> <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1523658266-2259-2-git-send-email-ruslan.bilovol@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ruslan Bilovol Cc: Jorge , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman List-Id: alsa-devel@alsa-project.org On Sat, 14 Apr 2018 00:24:23 +0200, Ruslan Bilovol wrote: > > Offload snd_usb_parse_audio_interface() function which > became quite long after adding UAC3 spec support. > > Move class-specific parts to separate functions > which now produce audioformat structure that is > ready to be fed to snd_usb_add_audio_stream(). > > This also broke Blue Microphones workaround (which > relies on audioformat decoded from previous altsetting) > into two parts: prepare quirk flag analyzing previous > altsetting then use it with current altsetting. > > Signed-off-by: Ruslan Bilovol Could you try to split this patch to two parts: one is a simple refactoring to move the code to snd_usb_get_audioformat_uac12(), and another to add snd_usb_get_audioformat_uac3(). In this way, we can see a problem more clearly if it's in the refactoring part. thanks, Takashi