From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 1/2] ALSA: pcm: add local header file for
	snd-pcm module
Date: Fri, 26 May 2017 08:40:10 +0200
Message-ID: <s5hbmqgjf3p.wl-tiwai@suse.de>
References: <20170526003047.17721-1-o-takashi@sakamocchi.jp>
 <20170526003047.17721-2-o-takashi@sakamocchi.jp>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 277BE26698E
 for <alsa-devel@alsa-project.org>; Fri, 26 May 2017 08:40:12 +0200 (CEST)
In-Reply-To: <20170526003047.17721-2-o-takashi@sakamocchi.jp>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

On Fri, 26 May 2017 02:30:46 +0200,
Takashi Sakamoto wrote:
> 
> Several files are used to construct PCM core module, a.k.a snd-pcm.
> Although available APIs are described in 'include/sound/pcm.h', some of
> them are not exported as symbols in kernel space. Such APIs are just for
> module local usage.
> 
> This commit adds module local header file and move some function prototypes
> into it so that scopes of them are controlled properly and developers
> get no confusion from unavailable symbols.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, now.  But...

> --- /dev/null
> +++ b/sound/core/pcm_local.h
> @@ -0,0 +1,51 @@
> +/*
> + * pcm_local.h - a local header file for snd-pcm module.
> + *
> + * Copyright (c) Takashi Sakamoto <o-takashi@sakamocchi.jp>
> + *
> + * Licensed under the terms of the GNU General Public License, version 2.
> + */

You don't have to declare always your name clearly there as if all
things were all your inventions solely :)


thanks,

Takashi