From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] pcm: Don't store the state for
	SND_PCM_STATE_SUSPENDED
Date: Wed, 01 Jun 2016 07:15:34 +0200
Message-ID: <s5hbn3ltrpl.wl-tiwai@suse.de>
References: <1462866346-11878-1-git-send-email-shengjiu.wang@freescale.com>
 <s5h7ff2b9vx.wl-tiwai@suse.de>
 <HE1PR04MB21229D4BBCC605559F98D3FFE3720@HE1PR04MB2122.eurprd04.prod.outlook.com>
 <s5hzirx9nv4.wl-tiwai@suse.de>
 <HE1PR04MB212240A8E6692FCFF12DF797E3720@HE1PR04MB2122.eurprd04.prod.outlook.com>
 <s5hoa8d9iey.wl-tiwai@suse.de>
 <HE1PR04MB2122FD4500AC192F85542DA2E3490@HE1PR04MB2122.eurprd04.prod.outlook.com>
 <s5h60ubn42y.wl-tiwai@suse.de>
 <HE1PR04MB212271FEAAEFBBE21A2E358FE34B0@HE1PR04MB2122.eurprd04.prod.outlook.com>
 <s5hk2ipknw2.wl-tiwai@suse.de> <s5hr3cwkdh6.wl-tiwai@suse.de>
 <DB5PR04MB212063DBF8904F58516C3137E34F0@DB5PR04MB2120.eurprd04.prod.outlook.com>
 <s5hvb23hi8l.wl-tiwai@suse.de> <s5hr3cmwoxd.wl-tiwai@suse.de>
 <HE1PR04MB2122B4E35FAB6FD526D88EEEE3460@HE1PR04MB2122.eurprd04.prod.outlook.com>
 <s5hmvn65wkp.wl-tiwai@suse.de>
 <HE1PR04MB2122B936112C26E400A9B5B4E3470@HE1PR04MB2122.eurprd04.prod.outlook.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id ED76326523B
 for <alsa-devel@alsa-project.org>; Wed,  1 Jun 2016 07:15:34 +0200 (CEST)
In-Reply-To: <HE1PR04MB2122B936112C26E400A9B5B4E3470@HE1PR04MB2122.eurprd04.prod.outlook.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
List-Id: alsa-devel@alsa-project.org

On Wed, 01 Jun 2016 05:10:41 +0200,
Shengjiu Wang wrote:
> 
> I test this patch, it is ok. But I have some questions.
> 
> 1. Why do you add snd_pcm_drop()? It seems only adding snd_pcm_resume(spcm)
> can fix this issue also.

The point is, that dmix *cannot* support resume by design.  It's very
same as dmix can't support pause, too.  The multiple streams on the
same slave can't be paused and restarted individually.

In ALSA scheme, the resume is triggered explicitly by app, not
automatically done in the driver.  Now imagine two streams running on
dmix.  The first stream resumes the slave, and both streams are
resumed.  Then, what is the state of the second stream?  It should
have been still suspended, but now it is running secretly.

> 2. Does the snd_pcm_drop cause some several period data be dropped?

Yes.  Very much same as others.

> 3. The return values -ENOSYS, always cause error print "Failed. Restarting
> stream." in aplay. Can it be fixed?

No, this is the expected behavior.  It's no error.


Takashi