All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Alexander E. Patrakov" <patrakov@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH 6/9] rate: handle negative values from snd_pcm_mmap_playback_hw_avail
Date: Tue, 16 Sep 2014 21:18:37 +0200	[thread overview]
Message-ID: <s5hd2av9xwy.wl-tiwai@suse.de> (raw)
In-Reply-To: <54185CD3.3030701@gmail.com>

At Tue, 16 Sep 2014 21:52:51 +0600,
Alexander E. Patrakov wrote:
> 
> 15.09.2014 16:14, Takashi Iwai wrote:
> > At Mon, 15 Sep 2014 16:03:57 +0600,
> > Alexander E. Patrakov wrote:
> >>
> >> 15.09.2014 14:49, Takashi Iwai пишет:
> >>> At Sun, 14 Sep 2014 00:30:18 +0600,
> >>> Alexander E. Patrakov wrote:
> >>>>
> >>>> Such negative returns are possible during an underrun if xrun detection
> >>>> is disabled.
> >>>>
> >>>> So, don't store the result in an unsigned variable (where it will
> >>>> overflow), and postpone the trigger in such case, too.
> >>>>
> >>>> Signed-off-by: Alexander E. Patrakov <patrakov@gmail.com>
> >>>> ---
> >>>>
> >>>> The patch is only compile-tested and the second hunk may well be wrong.
> >>>>
> >>>> There are also similar issues in pcm_share.c, but, as I don't completely
> >>>> understand the code there and cannot test that plugin at all due to
> >>>> unrelated crashes, there will be no patch from me.
> >>>
> >>> In general, hw_avail must not be negative before starting the stream.
> >>> If it is, then it means most likely the driver problem, so we should
> >>> return error immediately instead.
> >>
> >> Thanks for the review. Would -EBADFD be a correct error code, or do you
> >> want something different? or maybe even an assert?
> >
> > I'd take either EPIPE or EBADFD.
> > An assert would be an overkill, IMO.
> 
> I have sent the fix to the list, but nobody reacted. Resending as an 
> attachment to this message.

I'm traveling in this week, so please don't expect reactions in light
speed.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2014-09-16 19:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-13 18:30 [PATCH 0/9] Misc fixes related to rewinds Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 1/9] dmix: actually rewind when running or being drained Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 2/9] pcm: express the rewind size limitation logic better Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 3/9] pcm: handle negative values from snd_pcm_mmap_hw_avail Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 4/9] pcm, rate: use the snd_pcm_mmap_hw_avail function Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 5/9] pcm, null: use the snd_pcm_mmap_avail function Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 6/9] rate: handle negative values from snd_pcm_mmap_playback_hw_avail Alexander E. Patrakov
2014-09-15  8:49   ` Takashi Iwai
2014-09-15 10:03     ` Alexander E. Patrakov
2014-09-15 10:14       ` Takashi Iwai
2014-09-16 15:52         ` Alexander E. Patrakov
2014-09-16 17:26           ` Jaroslav Kysela
2014-09-16 19:18           ` Takashi Iwai [this message]
2014-09-13 18:30 ` [PATCH 7/9] dsnoop: rewindable and forwardable logic was swapped Alexander E. Patrakov
2014-09-13 18:30 ` [PATCH 8/9] pcm: rewindable, forwardable: don't return stale data Alexander E. Patrakov
2014-09-14  2:57   ` Raymond Yau
2014-09-13 18:30 ` [PATCH 9/9] pcm, file: don't recurse in the rewindable and forwardable callbacks Alexander E. Patrakov
2014-09-13 19:14 ` [PATCH 0/9] Misc fixes related to rewinds Jaroslav Kysela
2014-09-13 19:31   ` Alexander E. Patrakov
2014-09-13 19:50     ` Alexander E. Patrakov
2014-09-14 16:34       ` Jaroslav Kysela
2014-09-14  8:53 ` Raymond Yau
2014-09-14 10:11   ` Alexander E. Patrakov
2014-09-14 11:09     ` Alexander E. Patrakov
2014-09-14 11:19       ` Alexander E. Patrakov
2014-09-15  8:55         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd2av9xwy.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=patrakov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.