Re: A: VIA Technologies Inc. VT1720/24

[Takashi Iwai <tiwai@suse.de>]

At Thu, 25 Jan 2007 11:13:19 +0100,
Philipp Matthias Hahn wrote:
> 
> Hello Takashi!
> 
> On Wed, Jan 24, 2007 at 04:12:02PM +0100, Takashi Iwai wrote:
> > I recommend you to use the same string for this driver name here.
> 
> Yes.
> 
> > This string is referred by alsa-lib to pick up the corresponding
> > config file.  As Prodigy 7.1 Hifi is almost identical with Prodigy 7.1
> > LT from the configuration POV, it should use "Prodigy71LT", too, so
> > that you don't have to change alsa-lib at all.
> 
> No, the HiFi seems to be more like the Prodigy71 (without 'LT' or 'XT')
> But I might err. Is there something I can do to test is it has 3 or 4
> DACs, which seems to be the main difference?

Well, with our without LT doesn't matter because both are aliased to
Aureon71 in alsa-lib/src/conf/cards/alias.conf.

> > Otherwise changes look OK to me, but your patch conflicts with the
> > latest ALSA HG tree because of the patch applied prior to this.
> > Could you regenerate the patch to ALSA HG tree (with the fix above)?
> 
> Yes, see below. Three more questions:
> 1. Since the "Aureon7.1", "Prodigy7.1" and my "Prodigy7.1HiFi"; as well
> as the "Prodigy7.1LT" and the "Prodigy7.1XT" respectively seem so share
> the same EEPROM-Date, wouldn't it be better to re-use/share those
> eeprom-data instead of declaring them 3 respectively 2 times?
> Not much space saving, but gcc seems to be too stupid to recognize this;
> Even const'ifying the structures doesn't help.

Good point.  It's fine to merge them, of course.

> 2. Most arrays and structures seem to be read only, what about adding
> 'const' to them?

Yes, it's better.

> 3. Do you prefer array initialization in the form of
>  {1, 2, 3, } /* IDX0, IDX1, IDX2 */
> or as
>  { [IDX0] = 1, [IDX1] = 2, [IDX2] = 3, }

I don't care about this so much.  The former style has advantage that
you can copy the byte stream as it is while the latter is a better
coding style in general.  Though, if we change these things at once,
I'd take the latter style now.

IMO, it'd be better to split the changes to two patches, one for
cleaning up the above (merge to a single struct, add const and change 
the struct definition), and another to add 7.1 Hifi definition.

Could you work on these two patches?


thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV