All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: perex@perex.cz, alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctl: fix error path at adding user-defined element set
Date: Fri, 13 Nov 2020 11:34:39 +0100	[thread overview]
Message-ID: <s5heekxfsu8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201113092043.16148-1-o-takashi@sakamocchi.jp>

On Fri, 13 Nov 2020 10:20:43 +0100,
Takashi Sakamoto wrote:
> 
> When processing request to add/replace user-defined element set, check
> of given element identifier and decision of numeric identifier is done
> in "__snd_ctl_add_replace()" helper function. When the result of check
> is wrong, the helper function returns error code. The error code shall
> be returned to userspace application.
> 
> Current implementation includes bug to return zero to userspace application
> regardless of the result. This commit fixes the bug.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: e1a7bfe38079 ("ALSA: control: Fix race between adding and removing a user element")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied now.


Takashi

WARNING: multiple messages have this Message-ID
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: ctl: fix error path at adding user-defined element set
Date: Fri, 13 Nov 2020 11:34:39 +0100	[thread overview]
Message-ID: <s5heekxfsu8.wl-tiwai@suse.de> (raw)
In-Reply-To: <20201113092043.16148-1-o-takashi@sakamocchi.jp>

On Fri, 13 Nov 2020 10:20:43 +0100,
Takashi Sakamoto wrote:
> 
> When processing request to add/replace user-defined element set, check
> of given element identifier and decision of numeric identifier is done
> in "__snd_ctl_add_replace()" helper function. When the result of check
> is wrong, the helper function returns error code. The error code shall
> be returned to userspace application.
> 
> Current implementation includes bug to return zero to userspace application
> regardless of the result. This commit fixes the bug.
> 
> Cc: <stable@vger.kernel.org>
> Fixes: e1a7bfe38079 ("ALSA: control: Fix race between adding and removing a user element")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Thanks, applied now.


Takashi

  reply	other threads:[~2020-11-13 10:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  9:20 Takashi Sakamoto
2020-11-13 10:34 ` Takashi Iwai [this message]
2020-11-13 10:34   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5heekxfsu8.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH] ALSA: ctl: fix error path at adding user-defined element set' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.