From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC638C4742C for ; Fri, 13 Nov 2020 10:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E4AE22245 for ; Fri, 13 Nov 2020 10:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726288AbgKMKel (ORCPT ); Fri, 13 Nov 2020 05:34:41 -0500 Received: from mx2.suse.de ([195.135.220.15]:54892 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbgKMKek (ORCPT ); Fri, 13 Nov 2020 05:34:40 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 47712ACA8; Fri, 13 Nov 2020 10:34:39 +0000 (UTC) Date: Fri, 13 Nov 2020 11:34:39 +0100 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Cc: perex@perex.cz, alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: ctl: fix error path at adding user-defined element set In-Reply-To: <20201113092043.16148-1-o-takashi@sakamocchi.jp> References: <20201113092043.16148-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, 13 Nov 2020 10:20:43 +0100, Takashi Sakamoto wrote: > > When processing request to add/replace user-defined element set, check > of given element identifier and decision of numeric identifier is done > in "__snd_ctl_add_replace()" helper function. When the result of check > is wrong, the helper function returns error code. The error code shall > be returned to userspace application. > > Current implementation includes bug to return zero to userspace application > regardless of the result. This commit fixes the bug. > > Cc: > Fixes: e1a7bfe38079 ("ALSA: control: Fix race between adding and removing a user element") > Signed-off-by: Takashi Sakamoto Thanks, applied now. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AD5C4742C for ; Fri, 13 Nov 2020 10:35:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47D3722245 for ; Fri, 13 Nov 2020 10:35:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NTKKQ8Ju" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47D3722245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 880451785; Fri, 13 Nov 2020 11:34:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 880451785 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605263737; bh=dx4t3TOrVt7Vgv7UCks04N9/V4/mn9LReWkM4VvEOT0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NTKKQ8JuBLJTXk7g3E0T+s+52js7BCKIYyBRkTpT9lxj52osJDAyWmM7UrXoiOOgh S/BFso7/46s1sgFluXoKc+e5lgIFycHQ3PcWLCaoau/k6FaktfDoJegXEPXGs4B/Rr amVl6gFLEBlhuut9o7aPLZCVogZvXqZVbEhktb3U= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 15D61F801F5; Fri, 13 Nov 2020 11:34:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 484C8F802C4; Fri, 13 Nov 2020 11:34:45 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8BFE9F801F5 for ; Fri, 13 Nov 2020 11:34:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8BFE9F801F5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 47712ACA8; Fri, 13 Nov 2020 10:34:39 +0000 (UTC) Date: Fri, 13 Nov 2020 11:34:39 +0100 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH] ALSA: ctl: fix error path at adding user-defined element set In-Reply-To: <20201113092043.16148-1-o-takashi@sakamocchi.jp> References: <20201113092043.16148-1-o-takashi@sakamocchi.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 13 Nov 2020 10:20:43 +0100, Takashi Sakamoto wrote: > > When processing request to add/replace user-defined element set, check > of given element identifier and decision of numeric identifier is done > in "__snd_ctl_add_replace()" helper function. When the result of check > is wrong, the helper function returns error code. The error code shall > be returned to userspace application. > > Current implementation includes bug to return zero to userspace application > regardless of the result. This commit fixes the bug. > > Cc: > Fixes: e1a7bfe38079 ("ALSA: control: Fix race between adding and removing a user element") > Signed-off-by: Takashi Sakamoto Thanks, applied now. Takashi