From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C27C43218 for ; Sun, 28 Apr 2019 07:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DD2220881 for ; Sun, 28 Apr 2019 07:12:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbfD1HMR (ORCPT ); Sun, 28 Apr 2019 03:12:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:37132 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726133AbfD1HMQ (ORCPT ); Sun, 28 Apr 2019 03:12:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 94436AD63; Sun, 28 Apr 2019 07:12:15 +0000 (UTC) Date: Sun, 28 Apr 2019 09:12:15 +0200 Message-ID: From: Takashi Iwai To: "Wenwen Wang" Cc: "moderated list:SOUND" , "Jorge Sanjuan" , "Ruslan Bilovol" , "Jaroslav Kysela" , "open list" Subject: Re: [PATCH] ALSA: usb-audio: Fix a memory leak bug In-Reply-To: <1556345208-1210-1-git-send-email-wang6495@umn.edu> References: <1556345208-1210-1-git-send-email-wang6495@umn.edu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Apr 2019 08:06:46 +0200, Wenwen Wang wrote: > > In parse_audio_selector_unit(), the string array 'namelist' is allocated > through kmalloc_array(), and each string pointer in this array, i.e., > 'namelist[]', is allocated through kmalloc() in the following for loop. > Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If > an error occurs during the creation process, the string array 'namelist', > including all string pointers in the array 'namelist[]', should be freed, > before the error code ENOMEM is returned. However, the current code does > not free 'namelist[]', resulting in memory leaks. > > To fix the above issue, free all string pointers 'namelist[]' in a loop. > > Signed-off-by: Wenwen Wang Applied now, thanks. Takashi