From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753212AbdAZQX5 (ORCPT ); Thu, 26 Jan 2017 11:23:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:60538 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbdAZQX4 (ORCPT ); Thu, 26 Jan 2017 11:23:56 -0500 Date: Thu, 26 Jan 2017 17:03:46 +0100 Message-ID: From: Takashi Iwai To: "Bhumika Goyal" Cc: , , , Subject: Re: [PATCH v2] sound: pci: cs46xx: constify snd_pcm_ops structures In-Reply-To: <1485445265-19790-1-git-send-email-bhumirks@gmail.com> References: <1485445265-19790-1-git-send-email-bhumirks@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Jan 2017 16:41:05 +0100, Bhumika Goyal wrote: > > Declare snd_pcm_ops structures as const as they are either stored in the > ops field of a snd_pcm_substream structure or passed as an argument to > the function snd_pcm_set_ops. The function argument and the ops field > are of type const, so snd_pcm_ops structures having this property > can be made const too. > > File size before: sound/pci/cs46xx/cs46xx_lib.o > text data bss dec hex filename > 26047 5304 16 31367 7a87 sound/pci/cs46xx/cs46xx_lib.o > > File size after: sound/pci/cs46xx/cs46xx_lib.o > text data bss dec hex filename > 27335 4036 16 31387 7a9b sound/pci/cs46xx/cs46xx_lib.o > > Signed-off-by: Bhumika Goyal > --- > Changes in v2: > * test build the patch with CONFIG_SND_CS46XX_NEW_DSP=y Applied, thanks. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2] sound: pci: cs46xx: constify snd_pcm_ops structures Date: Thu, 26 Jan 2017 17:03:46 +0100 Message-ID: References: <1485445265-19790-1-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1485445265-19790-1-git-send-email-bhumirks@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Bhumika Goyal Cc: alsa-devel@alsa-project.org, julia.lawall@lip6.fr, perex@perex.cz, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Thu, 26 Jan 2017 16:41:05 +0100, Bhumika Goyal wrote: > > Declare snd_pcm_ops structures as const as they are either stored in the > ops field of a snd_pcm_substream structure or passed as an argument to > the function snd_pcm_set_ops. The function argument and the ops field > are of type const, so snd_pcm_ops structures having this property > can be made const too. > > File size before: sound/pci/cs46xx/cs46xx_lib.o > text data bss dec hex filename > 26047 5304 16 31367 7a87 sound/pci/cs46xx/cs46xx_lib.o > > File size after: sound/pci/cs46xx/cs46xx_lib.o > text data bss dec hex filename > 27335 4036 16 31387 7a9b sound/pci/cs46xx/cs46xx_lib.o > > Signed-off-by: Bhumika Goyal > --- > Changes in v2: > * test build the patch with CONFIG_SND_CS46XX_NEW_DSP=y Applied, thanks. Takashi