Re: [PATCH 2/3] ALSA - hda: Add support for link audio time reporting

[Takashi Iwai <tiwai@suse.de>]

On Fri, 15 Jul 2016 07:19:06 +0200,
Vinod Koul wrote:
> 
> On Fri, Jul 15, 2016 at 07:00:41AM +0200, Takashi Iwai wrote:
> > On Fri, 15 Jul 2016 06:37:21 +0200,
> > Vinod Koul wrote:
> > > 
> > > On Mon, Jul 11, 2016 at 07:43:25PM +0800, kbuild test robot wrote:
> > > > Hi,
> > > > 
> > > > [auto build test ERROR on sound/for-next]
> > > > [also build test ERROR on v4.7-rc7 next-20160711]
> > > > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > > > 
> > > > url:    https://github.com/0day-ci/linux/commits/Vinod-Koul/ALSA-hda-Add-support-for-link-audio-time-reporting/20160711-180949
> > > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
> > > > config: arm-multi_v7_defconfig (attached as .config)
> > > > compiler: arm-linux-gnueabi-gcc (Debian 5.3.1-8) 5.3.1 20160205
> > > > reproduce:
> > > >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         # save the attached .config to linux build tree
> > > >         make.cross ARCH=arm 
> > > > 
> > > > All errors (new ones prefixed by >>):
> > > > 
> > > > >> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
> > > >    compilation terminated.
> > > 
> > > Okay i think I need to move this bit into the intel code.
> > > 
> > > Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add
> > > this now. Are you okay with that?
> > 
> > Better to have an explicit ifdef CONFIG_X86 around it.  It's not only
> > for x86.
> 
> Need it around the whole of the timestamp code as well then..

Yes.  But why TSC is mandatory?  There is no explanation in your
patch.

> Yes the HDA controller is not x86 specfic, but the hda-intel should be,
> right?

No, the driver depends on PCI, but not on CPU.


thanks,

Takashi