From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it) Date: Thu, 29 Nov 2018 22:56:40 +0100 Message-ID: References: <20181126171126.20280-1-tiwai@suse.de> <20181127084418.GA20504@amd> <20181128111806.cb3cncpjeq73sptg@pali> <20181128122505.GA1193@amd> <8bb45cc6-9f98-9fed-9676-7f1429328c4a@gmail.com> <20181128203410.GA20670@amd> <20181128204612.l3bayhop4qmep2hj@pali> <0ed37870-c7b6-fd6b-2f6e-7325fdde3629@gmail.com> <20181128212212.GE20670@amd> <5f8eece3-95af-7866-d7d0-02cc3cb695ca@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5f8eece3-95af-7866-d7d0-02cc3cb695ca@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jacek Anaszewski Cc: alsa-devel@alsa-project.org, Ayman Bagabas , platform-driver-x86@vger.kernel.org, Hui Wang , ibm-acpi-devel@lists.sourceforge.net, Pavel Machek , Pali Roh1r , Andy Shevchenko , linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org On Thu, 29 Nov 2018 22:23:31 +0100, Jacek Anaszewski wrote: > > On 11/28/2018 10:22 PM, Pavel Machek wrote: > > Hi! > > > >>> If external USB keyboard is identified as "input7" device, then > >>> "input7::mute" is a good name for mute key. But "sys::mute" does not say > >>> anything to which device or hardware it belongs nor does not solve > >>> problem that which device/driver/subsystem should have privilege to take > >>> this "sys" name. > >> > >> How about just "platform" for the LEDs being part of the device > >> on which the system is running? > > > > "platform" works for me. > > > > Are we in agreement that this name will be used for all similar LEDs, > > as long as they are on the "main box" of the device, no matter if they > > are connected using acpi, gpio, i2c, ...? > > One doubt: say we have hdd activity LED on the "main box" - it > would be named "platform::disk". > > Now, we add external USB disk. Previously we were considering > the naming for disk LEDs in the form e.g. "sdb::disk". > > If so, there would be discrepancy between internal and external disk > LED names. Similarly in case of eth/adsl/wlan/camera LEDs. > > Regarding sound devices - how would we name micmute LED for USB > microphone? I suppose that it is possible to discover some unique > identifier in runtime - this is a question to ALSA people. There are little USB-audio devices supporting the LED control, so we haven't had any chance for LED class for USB-audio. At most, we may create LED class devices for some HD-audio (usually driven via exotic verbs or GPIO over HD-audio), but I wouldn't go in that direction; it'll need too make things more complex than the direct hook as of now. thanks, Takashi