From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932170AbbAESQx (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Jan 2015 13:16:53 -0500
Received: from cantor2.suse.de ([195.135.220.15]:59631 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754046AbbAESQw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Jan 2015 13:16:52 -0500
Date: Mon, 05 Jan 2015 19:16:49 +0100
Message-ID: <s5hfvbpf5ym.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Alex Deucher <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        Maling list - DRI developers 
	<dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/radeon: Fix kernel panic with HDMI w/o SAD
In-Reply-To: <CADnq5_OrxtFs=LMdXbX27WMbaWRdR7ALBDkL=ohP464qz3hhTw@mail.gmail.com>
References: <1420279798-961-1-git-send-email-tiwai@suse.de>
	<CADnq5_NU-nde7eBk_Ptpk6twk_aBrXZgLXxio3RiJUJ1D4ZzdQ@mail.gmail.com>
	<s5hioglf8ew.wl-tiwai@suse.de>
	<CADnq5_OrxtFs=LMdXbX27WMbaWRdR7ALBDkL=ohP464qz3hhTw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Mon, 5 Jan 2015 12:48:05 -0500,
Alex Deucher wrote:
> 
> On Mon, Jan 5, 2015 at 12:23 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > At Mon, 5 Jan 2015 12:07:52 -0500,
> > Alex Deucher wrote:
> >>
> >> On Sat, Jan 3, 2015 at 5:09 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > A BUG_ON() call in dce3_2_afmt_write_sad_regs() is triggered when a
> >> > HDMI monitor without audio is plugged:
> >>
> >> I have a slightly different fix already queued up:
> >> http://lists.freedesktop.org/archives/dri-devel/2014-December/073672.html
> >
> > Oh, that's identical with my v1 patch :)  But, with that fix, an error
> > message will be shown at each time you plug such a monitor, right?
> > This doesn't look right, so I revised the patch.
> 
> Yes, but if the monitor claims to support audio, it should supply
> SADs.  If it doesn't, the driver has no way of knowing what type of
> audio the monitor supports.

IMO, we may assume that the monitor has no audio at all if sad_count =
0.  Or are there any monitors that do support audio even without
SAD...?

> I'm fine with removing the error message
> or making it debug only however.

If sad_count = 0 is an invalid state that shouldn't happen, then
printing an error is correct behavior.  So, the question comes to the
point whether sad_count = 0 is a sane value or not.

> > Also, can we skip the register write completely?  I thought of a case
> > like we replug a monitor from the one with audio to another without
> > audio...
> 
> Changing the monitor will generally trigger a full probe and modeset
> again anyway.  The register writes are just there to pass the audio
> information supported by the monitor along to the audio driver.

OK, thanks for clarification.


In anyway, I still think we should kill BUG_ON() there.  But this can
be a separate patch, of course.


Takashi

> 
> Alex
> 
> >
> >
> > thanks,
> >
> > Takashi
> >
> >>
> >> Alex
> >>
> >> >
> >> >  kernel BUG at ../drivers/gpu/drm/radeon/dce3_1_afmt.c:110!
> >> >  invalid opcode: 0000 [#1] PREEMPT SMP
> >> >  CPU: 2 PID: 967 Comm: Xorg Tainted: PO  3.16.7-7-desktop #1
> >> >  Hardware name: System manufacturer System Product Name/M4A77T, BIOS 2401    05/18/2011
> >> >  task: ffff8800cea86350 ti: ffff8800c1880000 task.ti: ffff8800c1880000
> >> >  RIP: 0010:[<ffffffffa0126c50>] dce3_1_hdmi_setmode+0x570/0x5a0 [radeon]
> >> >  Call Trace:
> >> >   [<ffffffffa00a6936>] drm_crtc_helper_set_mode+0x346/0x520 [drm_kms_helper]
> >> >   [<ffffffffa00a7678>] drm_crtc_helper_set_config+0x8a8/0xad0 [drm_kms_helper]
> >> >   [<ffffffffa00ede3f>] radeon_crtc_set_config+0x3f/0x110 [radeon]
> >> >   [<ffffffffa001edc1>] drm_mode_set_config_internal+0x61/0xe0 [drm]
> >> >   [<ffffffffa00a9a6b>] restore_fbdev_mode+0xab/0xd0 [drm_kms_helper]
> >> >   [<ffffffffa00a9aae>] drm_fb_helper_restore_fbdev_mode_unlocked+0x1e/0x30 [drm_kms_helper]
> >> >   [<ffffffffa00ab642>] drm_fb_helper_set_par+0x22/0x60 [drm_kms_helper]
> >> >   [<ffffffffa00ab5cb>] drm_fb_helper_hotplug_event+0x8b/0xe0 [drm_kms_helper]
> >> >   [<ffffffffa00ab65a>] drm_fb_helper_set_par+0x3a/0x60 [drm_kms_helper]
> >> >   [<ffffffff813818ce>] fb_set_var+0x15e/0x3b0
> >> >   [<ffffffff81378d0b>] fbcon_blank+0x1cb/0x2b0
> >> >   [<ffffffff813f2a31>] do_unblank_screen+0xa1/0x1b0
> >> >   [<ffffffff813e8fd3>] complete_change_console+0x53/0xe0
> >> >   [<ffffffff813e9fa9>] vt_ioctl+0xf49/0x10d0
> >> >   [<ffffffff813ddfdc>] tty_ioctl+0x26c/0xb70
> >> >   [<ffffffff811cad17>] do_vfs_ioctl+0x2e7/0x4c0
> >> >   [<ffffffff811caf71>] SyS_ioctl+0x81/0xa0
> >> >   [<ffffffff81622a2d>] system_call_fastpath+0x1a/0x1f
> >> >   [<00007f2fae8c6397>] 0x7f2fae8c6396
> >> >
> >> > Actually the BUG_ON() check is wrong, since sads may be NULL when
> >> > sad_count is zero.  This patch removes the BUG_ON() and adds the
> >> > proper NULL initialization of sads.
> >> >
> >> > Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=911356
> >> > Cc: <stable@vger.kernel.org>
> >> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >> > ---
> >> >  drivers/gpu/drm/radeon/dce3_1_afmt.c | 3 +--
> >> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/radeon/dce3_1_afmt.c b/drivers/gpu/drm/radeon/dce3_1_afmt.c
> >> > index 2fe8cfc966d9..7ca23f45829e 100644
> >> > --- a/drivers/gpu/drm/radeon/dce3_1_afmt.c
> >> > +++ b/drivers/gpu/drm/radeon/dce3_1_afmt.c
> >> > @@ -72,7 +72,7 @@ static void dce3_2_afmt_write_sad_regs(struct drm_encoder *encoder)
> >> >         struct radeon_device *rdev = encoder->dev->dev_private;
> >> >         struct drm_connector *connector;
> >> >         struct radeon_connector *radeon_connector = NULL;
> >> > -       struct cea_sad *sads;
> >> > +       struct cea_sad *sads = NULL;
> >> >         int i, sad_count;
> >> >
> >> >         static const u16 eld_reg_to_type[][2] = {
> >> > @@ -107,7 +107,6 @@ static void dce3_2_afmt_write_sad_regs(struct drm_encoder *encoder)
> >> >                 DRM_ERROR("Couldn't read SADs: %d\n", sad_count);
> >> >                 return;
> >> >         }
> >> > -       BUG_ON(!sads);
> >> >
> >> >         for (i = 0; i < ARRAY_SIZE(eld_reg_to_type); i++) {
> >> >                 u32 value = 0;
> >> > --
> >> > 2.2.0
> >> >
> >> > _______________________________________________
> >> > dri-devel mailing list
> >> > dri-devel@lists.freedesktop.org
> >> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >>
> 

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2] drm/radeon: Fix kernel panic with HDMI w/o SAD
Date: Mon, 05 Jan 2015 19:16:49 +0100
Message-ID: <s5hfvbpf5ym.wl-tiwai@suse.de>
References: <1420279798-961-1-git-send-email-tiwai@suse.de>
 <CADnq5_NU-nde7eBk_Ptpk6twk_aBrXZgLXxio3RiJUJ1D4ZzdQ@mail.gmail.com>
 <s5hioglf8ew.wl-tiwai@suse.de>
 <CADnq5_OrxtFs=LMdXbX27WMbaWRdR7ALBDkL=ohP464qz3hhTw@mail.gmail.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
 by gabe.freedesktop.org (Postfix) with ESMTP id 59BF96E023
 for <dri-devel@lists.freedesktop.org>; Mon,  5 Jan 2015 10:16:52 -0800 (PST)
In-Reply-To: <CADnq5_OrxtFs=LMdXbX27WMbaWRdR7ALBDkL=ohP464qz3hhTw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, Christian Koenig <christian.koenig@amd.com>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>
List-Id: dri-devel@lists.freedesktop.org

QXQgTW9uLCA1IEphbiAyMDE1IDEyOjQ4OjA1IC0wNTAwLApBbGV4IERldWNoZXIgd3JvdGU6Cj4g
Cj4gT24gTW9uLCBKYW4gNSwgMjAxNSBhdCAxMjoyMyBQTSwgVGFrYXNoaSBJd2FpIDx0aXdhaUBz
dXNlLmRlPiB3cm90ZToKPiA+IEF0IE1vbiwgNSBKYW4gMjAxNSAxMjowNzo1MiAtMDUwMCwKPiA+
IEFsZXggRGV1Y2hlciB3cm90ZToKPiA+Pgo+ID4+IE9uIFNhdCwgSmFuIDMsIDIwMTUgYXQgNTow
OSBBTSwgVGFrYXNoaSBJd2FpIDx0aXdhaUBzdXNlLmRlPiB3cm90ZToKPiA+PiA+IEEgQlVHX09O
KCkgY2FsbCBpbiBkY2UzXzJfYWZtdF93cml0ZV9zYWRfcmVncygpIGlzIHRyaWdnZXJlZCB3aGVu
IGEKPiA+PiA+IEhETUkgbW9uaXRvciB3aXRob3V0IGF1ZGlvIGlzIHBsdWdnZWQ6Cj4gPj4KPiA+
PiBJIGhhdmUgYSBzbGlnaHRseSBkaWZmZXJlbnQgZml4IGFscmVhZHkgcXVldWVkIHVwOgo+ID4+
IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTQtRGVj
ZW1iZXIvMDczNjcyLmh0bWwKPiA+Cj4gPiBPaCwgdGhhdCdzIGlkZW50aWNhbCB3aXRoIG15IHYx
IHBhdGNoIDopICBCdXQsIHdpdGggdGhhdCBmaXgsIGFuIGVycm9yCj4gPiBtZXNzYWdlIHdpbGwg
YmUgc2hvd24gYXQgZWFjaCB0aW1lIHlvdSBwbHVnIHN1Y2ggYSBtb25pdG9yLCByaWdodD8KPiA+
IFRoaXMgZG9lc24ndCBsb29rIHJpZ2h0LCBzbyBJIHJldmlzZWQgdGhlIHBhdGNoLgo+IAo+IFll
cywgYnV0IGlmIHRoZSBtb25pdG9yIGNsYWltcyB0byBzdXBwb3J0IGF1ZGlvLCBpdCBzaG91bGQg
c3VwcGx5Cj4gU0FEcy4gIElmIGl0IGRvZXNuJ3QsIHRoZSBkcml2ZXIgaGFzIG5vIHdheSBvZiBr
bm93aW5nIHdoYXQgdHlwZSBvZgo+IGF1ZGlvIHRoZSBtb25pdG9yIHN1cHBvcnRzLgoKSU1PLCB3
ZSBtYXkgYXNzdW1lIHRoYXQgdGhlIG1vbml0b3IgaGFzIG5vIGF1ZGlvIGF0IGFsbCBpZiBzYWRf
Y291bnQgPQowLiAgT3IgYXJlIHRoZXJlIGFueSBtb25pdG9ycyB0aGF0IGRvIHN1cHBvcnQgYXVk
aW8gZXZlbiB3aXRob3V0ClNBRC4uLj8KCj4gSSdtIGZpbmUgd2l0aCByZW1vdmluZyB0aGUgZXJy
b3IgbWVzc2FnZQo+IG9yIG1ha2luZyBpdCBkZWJ1ZyBvbmx5IGhvd2V2ZXIuCgpJZiBzYWRfY291
bnQgPSAwIGlzIGFuIGludmFsaWQgc3RhdGUgdGhhdCBzaG91bGRuJ3QgaGFwcGVuLCB0aGVuCnBy
aW50aW5nIGFuIGVycm9yIGlzIGNvcnJlY3QgYmVoYXZpb3IuICBTbywgdGhlIHF1ZXN0aW9uIGNv
bWVzIHRvIHRoZQpwb2ludCB3aGV0aGVyIHNhZF9jb3VudCA9IDAgaXMgYSBzYW5lIHZhbHVlIG9y
IG5vdC4KCj4gPiBBbHNvLCBjYW4gd2Ugc2tpcCB0aGUgcmVnaXN0ZXIgd3JpdGUgY29tcGxldGVs
eT8gIEkgdGhvdWdodCBvZiBhIGNhc2UKPiA+IGxpa2Ugd2UgcmVwbHVnIGEgbW9uaXRvciBmcm9t
IHRoZSBvbmUgd2l0aCBhdWRpbyB0byBhbm90aGVyIHdpdGhvdXQKPiA+IGF1ZGlvLi4uCj4gCj4g
Q2hhbmdpbmcgdGhlIG1vbml0b3Igd2lsbCBnZW5lcmFsbHkgdHJpZ2dlciBhIGZ1bGwgcHJvYmUg
YW5kIG1vZGVzZXQKPiBhZ2FpbiBhbnl3YXkuICBUaGUgcmVnaXN0ZXIgd3JpdGVzIGFyZSBqdXN0
IHRoZXJlIHRvIHBhc3MgdGhlIGF1ZGlvCj4gaW5mb3JtYXRpb24gc3VwcG9ydGVkIGJ5IHRoZSBt
b25pdG9yIGFsb25nIHRvIHRoZSBhdWRpbyBkcml2ZXIuCgpPSywgdGhhbmtzIGZvciBjbGFyaWZp
Y2F0aW9uLgoKCkluIGFueXdheSwgSSBzdGlsbCB0aGluayB3ZSBzaG91bGQga2lsbCBCVUdfT04o
KSB0aGVyZS4gIEJ1dCB0aGlzIGNhbgpiZSBhIHNlcGFyYXRlIHBhdGNoLCBvZiBjb3Vyc2UuCgoK
VGFrYXNoaQoKPiAKPiBBbGV4Cj4gCj4gPgo+ID4KPiA+IHRoYW5rcywKPiA+Cj4gPiBUYWthc2hp
Cj4gPgo+ID4+Cj4gPj4gQWxleAo+ID4+Cj4gPj4gPgo+ID4+ID4gIGtlcm5lbCBCVUcgYXQgLi4v
ZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9kY2UzXzFfYWZtdC5jOjExMCEKPiA+PiA+ICBpbnZhbGlk
IG9wY29kZTogMDAwMCBbIzFdIFBSRUVNUFQgU01QCj4gPj4gPiAgQ1BVOiAyIFBJRDogOTY3IENv
bW06IFhvcmcgVGFpbnRlZDogUE8gIDMuMTYuNy03LWRlc2t0b3AgIzEKPiA+PiA+ICBIYXJkd2Fy
ZSBuYW1lOiBTeXN0ZW0gbWFudWZhY3R1cmVyIFN5c3RlbSBQcm9kdWN0IE5hbWUvTTRBNzdULCBC
SU9TIDI0MDEgICAgMDUvMTgvMjAxMQo+ID4+ID4gIHRhc2s6IGZmZmY4ODAwY2VhODYzNTAgdGk6
IGZmZmY4ODAwYzE4ODAwMDAgdGFzay50aTogZmZmZjg4MDBjMTg4MDAwMAo+ID4+ID4gIFJJUDog
MDAxMDpbPGZmZmZmZmZmYTAxMjZjNTA+XSBkY2UzXzFfaGRtaV9zZXRtb2RlKzB4NTcwLzB4NWEw
IFtyYWRlb25dCj4gPj4gPiAgQ2FsbCBUcmFjZToKPiA+PiA+ICAgWzxmZmZmZmZmZmEwMGE2OTM2
Pl0gZHJtX2NydGNfaGVscGVyX3NldF9tb2RlKzB4MzQ2LzB4NTIwIFtkcm1fa21zX2hlbHBlcl0K
PiA+PiA+ICAgWzxmZmZmZmZmZmEwMGE3Njc4Pl0gZHJtX2NydGNfaGVscGVyX3NldF9jb25maWcr
MHg4YTgvMHhhZDAgW2RybV9rbXNfaGVscGVyXQo+ID4+ID4gICBbPGZmZmZmZmZmYTAwZWRlM2Y+
XSByYWRlb25fY3J0Y19zZXRfY29uZmlnKzB4M2YvMHgxMTAgW3JhZGVvbl0KPiA+PiA+ICAgWzxm
ZmZmZmZmZmEwMDFlZGMxPl0gZHJtX21vZGVfc2V0X2NvbmZpZ19pbnRlcm5hbCsweDYxLzB4ZTAg
W2RybV0KPiA+PiA+ICAgWzxmZmZmZmZmZmEwMGE5YTZiPl0gcmVzdG9yZV9mYmRldl9tb2RlKzB4
YWIvMHhkMCBbZHJtX2ttc19oZWxwZXJdCj4gPj4gPiAgIFs8ZmZmZmZmZmZhMDBhOWFhZT5dIGRy
bV9mYl9oZWxwZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKzB4MWUvMHgzMCBbZHJtX2tt
c19oZWxwZXJdCj4gPj4gPiAgIFs8ZmZmZmZmZmZhMDBhYjY0Mj5dIGRybV9mYl9oZWxwZXJfc2V0
X3BhcisweDIyLzB4NjAgW2RybV9rbXNfaGVscGVyXQo+ID4+ID4gICBbPGZmZmZmZmZmYTAwYWI1
Y2I+XSBkcm1fZmJfaGVscGVyX2hvdHBsdWdfZXZlbnQrMHg4Yi8weGUwIFtkcm1fa21zX2hlbHBl
cl0KPiA+PiA+ICAgWzxmZmZmZmZmZmEwMGFiNjVhPl0gZHJtX2ZiX2hlbHBlcl9zZXRfcGFyKzB4
M2EvMHg2MCBbZHJtX2ttc19oZWxwZXJdCj4gPj4gPiAgIFs8ZmZmZmZmZmY4MTM4MThjZT5dIGZi
X3NldF92YXIrMHgxNWUvMHgzYjAKPiA+PiA+ICAgWzxmZmZmZmZmZjgxMzc4ZDBiPl0gZmJjb25f
YmxhbmsrMHgxY2IvMHgyYjAKPiA+PiA+ICAgWzxmZmZmZmZmZjgxM2YyYTMxPl0gZG9fdW5ibGFu
a19zY3JlZW4rMHhhMS8weDFiMAo+ID4+ID4gICBbPGZmZmZmZmZmODEzZThmZDM+XSBjb21wbGV0
ZV9jaGFuZ2VfY29uc29sZSsweDUzLzB4ZTAKPiA+PiA+ICAgWzxmZmZmZmZmZjgxM2U5ZmE5Pl0g
dnRfaW9jdGwrMHhmNDkvMHgxMGQwCj4gPj4gPiAgIFs8ZmZmZmZmZmY4MTNkZGZkYz5dIHR0eV9p
b2N0bCsweDI2Yy8weGI3MAo+ID4+ID4gICBbPGZmZmZmZmZmODExY2FkMTc+XSBkb192ZnNfaW9j
dGwrMHgyZTcvMHg0YzAKPiA+PiA+ICAgWzxmZmZmZmZmZjgxMWNhZjcxPl0gU3lTX2lvY3RsKzB4
ODEvMHhhMAo+ID4+ID4gICBbPGZmZmZmZmZmODE2MjJhMmQ+XSBzeXN0ZW1fY2FsbF9mYXN0cGF0
aCsweDFhLzB4MWYKPiA+PiA+ICAgWzwwMDAwN2YyZmFlOGM2Mzk3Pl0gMHg3ZjJmYWU4YzYzOTYK
PiA+PiA+Cj4gPj4gPiBBY3R1YWxseSB0aGUgQlVHX09OKCkgY2hlY2sgaXMgd3JvbmcsIHNpbmNl
IHNhZHMgbWF5IGJlIE5VTEwgd2hlbgo+ID4+ID4gc2FkX2NvdW50IGlzIHplcm8uICBUaGlzIHBh
dGNoIHJlbW92ZXMgdGhlIEJVR19PTigpIGFuZCBhZGRzIHRoZQo+ID4+ID4gcHJvcGVyIE5VTEwg
aW5pdGlhbGl6YXRpb24gb2Ygc2Fkcy4KPiA+PiA+Cj4gPj4gPiBCdWd6aWxsYTogaHR0cHM6Ly9i
dWd6aWxsYS5vcGVuc3VzZS5vcmcvc2hvd19idWcuY2dpP2lkPTkxMTM1Ngo+ID4+ID4gQ2M6IDxz
dGFibGVAdmdlci5rZXJuZWwub3JnPgo+ID4+ID4gU2lnbmVkLW9mZi1ieTogVGFrYXNoaSBJd2Fp
IDx0aXdhaUBzdXNlLmRlPgo+ID4+ID4gLS0tCj4gPj4gPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv
bi9kY2UzXzFfYWZtdC5jIHwgMyArLS0KPiA+PiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKyksIDIgZGVsZXRpb25zKC0pCj4gPj4gPgo+ID4+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9yYWRlb24vZGNlM18xX2FmbXQuYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vZGNl
M18xX2FmbXQuYwo+ID4+ID4gaW5kZXggMmZlOGNmYzk2NmQ5Li43Y2EyM2Y0NTgyOWUgMTAwNjQ0
Cj4gPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2RjZTNfMV9hZm10LmMKPiA+PiA+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vZGNlM18xX2FmbXQuYwo+ID4+ID4gQEAgLTcy
LDcgKzcyLDcgQEAgc3RhdGljIHZvaWQgZGNlM18yX2FmbXRfd3JpdGVfc2FkX3JlZ3Moc3RydWN0
IGRybV9lbmNvZGVyICplbmNvZGVyKQo+ID4+ID4gICAgICAgICBzdHJ1Y3QgcmFkZW9uX2Rldmlj
ZSAqcmRldiA9IGVuY29kZXItPmRldi0+ZGV2X3ByaXZhdGU7Cj4gPj4gPiAgICAgICAgIHN0cnVj
dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gPj4gPiAgICAgICAgIHN0cnVjdCByYWRlb25f
Y29ubmVjdG9yICpyYWRlb25fY29ubmVjdG9yID0gTlVMTDsKPiA+PiA+IC0gICAgICAgc3RydWN0
IGNlYV9zYWQgKnNhZHM7Cj4gPj4gPiArICAgICAgIHN0cnVjdCBjZWFfc2FkICpzYWRzID0gTlVM
TDsKPiA+PiA+ICAgICAgICAgaW50IGksIHNhZF9jb3VudDsKPiA+PiA+Cj4gPj4gPiAgICAgICAg
IHN0YXRpYyBjb25zdCB1MTYgZWxkX3JlZ190b190eXBlW11bMl0gPSB7Cj4gPj4gPiBAQCAtMTA3
LDcgKzEwNyw2IEBAIHN0YXRpYyB2b2lkIGRjZTNfMl9hZm10X3dyaXRlX3NhZF9yZWdzKHN0cnVj
dCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiA+PiA+ICAgICAgICAgICAgICAgICBEUk1fRVJST1Io
IkNvdWxkbid0IHJlYWQgU0FEczogJWRcbiIsIHNhZF9jb3VudCk7Cj4gPj4gPiAgICAgICAgICAg
ICAgICAgcmV0dXJuOwo+ID4+ID4gICAgICAgICB9Cj4gPj4gPiAtICAgICAgIEJVR19PTighc2Fk
cyk7Cj4gPj4gPgo+ID4+ID4gICAgICAgICBmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShlbGRf
cmVnX3RvX3R5cGUpOyBpKyspIHsKPiA+PiA+ICAgICAgICAgICAgICAgICB1MzIgdmFsdWUgPSAw
Owo+ID4+ID4gLS0KPiA+PiA+IDIuMi4wCj4gPj4gPgo+ID4+ID4gX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+PiA+IGRyaS1kZXZlbCBtYWlsaW5nIGxp
c3QKPiA+PiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiA+IGh0dHA6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiA+Pgo+IApf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg
bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz
LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=