From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A0F6C433F5 for ; Sun, 10 Oct 2021 20:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E65E60F55 for ; Sun, 10 Oct 2021 20:26:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232537AbhJJU2L (ORCPT ); Sun, 10 Oct 2021 16:28:11 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:56430 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbhJJU2K (ORCPT ); Sun, 10 Oct 2021 16:28:10 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B87091FD4C; Sun, 10 Oct 2021 20:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633897570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJC2KoQ+Qb7tBG8ADatZhzgv/vS/Dwb4Q2ZnO1dzMqg=; b=dbPegV7wEdCs3VwDXGXDvZkAfofxhV9oDx0RcUaczlbwvWFIWhWH7cAARlkt4h2zblvSAN uHFBFqVAsLGktgM1Z9rXX7BPCXlyWMRbBNZYnvb3E+BiHgLNQC8etC+vEDZKF1M8ClEoPa fGKKpMPifP5ovJCTt0LIfCC89ikMsWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633897570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJC2KoQ+Qb7tBG8ADatZhzgv/vS/Dwb4Q2ZnO1dzMqg=; b=skwvTvWdsz3TTSIl4EKsR3eEmz3Rht4Yp4Hl2IEeM1Y/9qFwOorweabOiO9c1ZIVtDkvn2 ysKUGVXOTkJ/l7DQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id A4EE0A3B83; Sun, 10 Oct 2021 20:26:10 +0000 (UTC) Date: Sun, 10 Oct 2021 22:26:10 +0200 Message-ID: From: Takashi Iwai To: Jonas Hahnfeld Cc: Takashi Iwai , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770 In-Reply-To: <20211010111947.5796-1-hahnjo@hahnjo.de> References: <20211010111947.5796-1-hahnjo@hahnjo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Oct 2021 13:19:47 +0200, Jonas Hahnfeld wrote: > > The device advertises 8 formats, but only a rate of 48kHz is honored > by the hardware and 24 bits give chopped audio, so only report the > one working combination. This fixes out-of-the-box audio experience > with PipeWire which otherwise attempts to choose S24_3LE (while > PulseAudio defaulted to S16_LE). > > Signed-off-by: Jonas Hahnfeld Could you give alsa-info.sh output with and without patch, just for comparison? Run the script with --no-upload option and attach the outputs. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFE2C433EF for ; Sun, 10 Oct 2021 20:27:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5742E60F3A for ; Sun, 10 Oct 2021 20:27:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5742E60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2F864167E; Sun, 10 Oct 2021 22:26:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2F864167E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633897629; bh=CSm3UdQ339152SHO3LA/+fRoRqzHeWUMosfJYsrXDZE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=g+aCDPSoALupBJTTd8GALPn93nYjPuEEQkj1tThCyreqjYfCJUjatSgtaIuYDcSwO qeW394zo7mIKV66qowxMcbeMZUJB1v3plXx7DE+JHBouxR4xTGE8LSnNeI5KP+P1XM KXOkT+vMnHoYRwZjnblEqF/9EprRPS59M0pjtVeY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C8708F80212; Sun, 10 Oct 2021 22:26:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 797D1F80212; Sun, 10 Oct 2021 22:26:17 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 70C80F80059 for ; Sun, 10 Oct 2021 22:26:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 70C80F80059 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="dbPegV7w"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="skwvTvWd" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id B87091FD4C; Sun, 10 Oct 2021 20:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633897570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJC2KoQ+Qb7tBG8ADatZhzgv/vS/Dwb4Q2ZnO1dzMqg=; b=dbPegV7wEdCs3VwDXGXDvZkAfofxhV9oDx0RcUaczlbwvWFIWhWH7cAARlkt4h2zblvSAN uHFBFqVAsLGktgM1Z9rXX7BPCXlyWMRbBNZYnvb3E+BiHgLNQC8etC+vEDZKF1M8ClEoPa fGKKpMPifP5ovJCTt0LIfCC89ikMsWA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633897570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJC2KoQ+Qb7tBG8ADatZhzgv/vS/Dwb4Q2ZnO1dzMqg=; b=skwvTvWdsz3TTSIl4EKsR3eEmz3Rht4Yp4Hl2IEeM1Y/9qFwOorweabOiO9c1ZIVtDkvn2 ysKUGVXOTkJ/l7DQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id A4EE0A3B83; Sun, 10 Oct 2021 20:26:10 +0000 (UTC) Date: Sun, 10 Oct 2021 22:26:10 +0200 Message-ID: From: Takashi Iwai To: Jonas Hahnfeld Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770 In-Reply-To: <20211010111947.5796-1-hahnjo@hahnjo.de> References: <20211010111947.5796-1-hahnjo@hahnjo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 10 Oct 2021 13:19:47 +0200, Jonas Hahnfeld wrote: > > The device advertises 8 formats, but only a rate of 48kHz is honored > by the hardware and 24 bits give chopped audio, so only report the > one working combination. This fixes out-of-the-box audio experience > with PipeWire which otherwise attempts to choose S24_3LE (while > PulseAudio defaulted to S16_LE). > > Signed-off-by: Jonas Hahnfeld Could you give alsa-info.sh output with and without patch, just for comparison? Run the script with --no-upload option and attach the outputs. thanks, Takashi