From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F954C43331 for ; Tue, 31 Mar 2020 12:36:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08CCE2072E for ; Tue, 31 Mar 2020 12:36:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="dWOmtJSI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08CCE2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 52A6A86F; Tue, 31 Mar 2020 14:36:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 52A6A86F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585658211; bh=5gvMS5M6Lbun8HW+LOmGFiqvbk5enbVrJTrTiquNo/E=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dWOmtJSIozgpHAwWIVVJduMe1fai0CXei4rVcBvDCffsABQvPIfifPIPzf8MZkJe4 otIns5ZrgOXA4dyffslDKuGymGWuUTx7rGlJOtOMgrt2Y7kac2j5s8WjtrbSIUc8AC RAoa8EN1W0Sf1ponDbY7Sbp2e/ceBX+ZHC2IHaQI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B89DAF80140; Tue, 31 Mar 2020 14:36:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E9CD7F80146; Tue, 31 Mar 2020 14:35:58 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D6F5BF8010D for ; Tue, 31 Mar 2020 14:35:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D6F5BF8010D X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BD23EAD3C; Tue, 31 Mar 2020 12:35:54 +0000 (UTC) Date: Tue, 31 Mar 2020 14:35:54 +0200 Message-ID: From: Takashi Iwai To: Andreas Steinmetz Subject: Re: PATCH v2: ALSA USB MIDI: Fix case when USB MIDI interface has more than one extra endpoint descriptor In-Reply-To: <1c3b431a86f69e1d60745b6110cdb93c299f120b.camel@domdv.de> References: <00decacc4cac6a9d88fe696f94a077284fb8bbb9.camel@domdv.de> <1c3b431a86f69e1d60745b6110cdb93c299f120b.camel@domdv.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, clemens@ladisch.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 31 Mar 2020 14:25:54 +0200, Andreas Steinmetz wrote: > > [v2: Patch reworked as per comment from Takashi Iwai.] > > The Miditech MIDIFACE 16x16 (USB ID 1290:1749) has more than one extra > endpoint descriptor. > > The first extra descriptor is: 0x06 0x30 0x00 0x00 0x00 0x00 > > As the code in snd_usbmidi_get_ms_info() looks only at the > first extra descriptor to find USB_DT_CS_ENDPOINT the device > as such is recognized but there is neither input nor output > configured. > > The patch iterates through the extra descriptors to find the > proper one. With this patch the device is correctly configured. > > Signed-off-by: Andreas Steinmetz Applied now. Thanks. Takashi