From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 6/6] ASoC: samsung: Fix of-node refcount unbalance in odroid_audio_probe() Date: Wed, 20 Feb 2019 11:40:24 +0100 Message-ID: References: <20190219154652.13644-1-tiwai@suse.de> <20190219154652.13644-7-tiwai@suse.de> <69d7e286-9ae0-71c8-af82-cc5eb4919d16@samsung.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6325BF80758 for ; Wed, 20 Feb 2019 11:40:25 +0100 (CET) In-Reply-To: <69d7e286-9ae0-71c8-af82-cc5eb4919d16@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Sylwester Nawrocki Cc: Sangbeom Kim , alsa-devel@alsa-project.org, Mark Brown , Krzysztof Kozlowski List-Id: alsa-devel@alsa-project.org On Tue, 19 Feb 2019 17:36:56 +0100, Sylwester Nawrocki wrote: > > On 2/19/19 16:46, Takashi Iwai wrote: > > odroid_audio_probe() leaves of-nodes without unreferenced after use. > > Fix it by shuffling some code a bit and add the missing of_node_put() > > calls accordingly. > > > > Fixes: aba611fc4c69 ("ASoC: samsung: Add Odroid ASoC machine driver") > > Cc: Krzysztof Kozlowski > > Cc: Sangbeom Kim > > Cc: Sylwester Nawrocki > > Signed-off-by: Takashi Iwai > > --- > > > > Only compile-tested. Please review carefully. Thanks! > Thanks for the patch. Current code for 5.1 is a bit different and we > may now need something like: Ah thanks, I forgot to follow asoc repo since merging to sound.git tree in this regard. Care to submit the patch for the latest tree from your side? Thanks! Takashi