All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	alsa-devel@alsa-project.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v1] ASoC: rt5677: Convert I2C driver to ->probe_new()
Date: Thu, 24 Aug 2017 16:33:29 +0200	[thread overview]
Message-ID: <s5hh8wxjarq.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170824134924.uwzksz6ln43nurdd@sirena.org.uk>

On Thu, 24 Aug 2017 15:49:24 +0200,
Mark Brown wrote:
> 
> On Thu, Aug 24, 2017 at 04:41:10PM +0300, Andy Shevchenko wrote:
> 
> > There is no platform code that uses i2c module table.
> > Remove it altogether and adjust ->probe() to be ->probe_new().
> 
> What is the value in doing this?  Removing the ability to instantiate
> via board files is just inconveniencing people doing that, it's not a
> goal in itself.

But the id table is already empty...?


Takashi

  reply	other threads:[~2017-08-24 14:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 13:41 [PATCH v1] ASoC: rt5677: Convert I2C driver to ->probe_new() Andy Shevchenko
2017-08-24 13:49 ` Mark Brown
2017-08-24 14:33   ` Takashi Iwai [this message]
2017-08-24 15:49     ` Mark Brown
2017-08-24 16:11       ` Takashi Iwai
2017-08-24 17:12         ` Andy Shevchenko
2017-08-25 13:56           ` Mark Brown
2017-08-25 13:11         ` Mark Brown
2017-08-25 13:33           ` Andy Shevchenko
2017-08-25 14:21             ` Mark Brown
2017-08-25 15:09               ` Andy Shevchenko
2017-08-25 18:59                 ` Mark Brown
2018-05-18 15:41 Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hh8wxjarq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.