From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932164AbdEKIqu (ORCPT ); Thu, 11 May 2017 04:46:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:53724 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932089AbdEKIqt (ORCPT ); Thu, 11 May 2017 04:46:49 -0400 Date: Thu, 11 May 2017 10:46:47 +0200 Message-ID: From: Takashi Iwai To: Christoph Hellwig Cc: Jaroslav Kysela , Linus Torvalds , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] future of sounds/oss In-Reply-To: <20170511082133.GA20304@lst.de> References: <20170511082133.GA20304@lst.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2017 10:21:33 +0200, Christoph Hellwig wrote: > > Ho Jaroslav, hi Takashi, > > do you know who still uses the sound/oss drivers and why? I've > recently been looking into getting rid of set_fs for using > copy_{from,to}_user and friends on kernel pointers, and the sound > code is a big abuser, both ALSA and the legacy OSS code. Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest. But the set_fs() usage in OSS code is hard to get rid of, due to the in-kernel ioctl calls, and I really don't want to touch such dusty codes, either. So I wanted to post the very same question, but you were faster :) > But looking at the OSS code it's pretty grotty, and also appears > to be pretty much unmaintained except for global cleanups. Is there > any chance we could look into getting rid of it over the next few > merge windows or are there people that rely on it? I don't think there are any active users. The only slight concern is that there are a few ancient devices that are supported only by some OSS drivers. But these are over decades, and very unlikely alive. That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig. The latter can be done even for 4.12, if Linus doesn't mind. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: future of sounds/oss Date: Thu, 11 May 2017 10:46:47 +0200 Message-ID: References: <20170511082133.GA20304@lst.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BFD8A266EF9 for ; Thu, 11 May 2017 10:46:48 +0200 (CEST) In-Reply-To: <20170511082133.GA20304@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Linus Torvalds , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 11 May 2017 10:21:33 +0200, Christoph Hellwig wrote: > > Ho Jaroslav, hi Takashi, > > do you know who still uses the sound/oss drivers and why? I've > recently been looking into getting rid of set_fs for using > copy_{from,to}_user and friends on kernel pointers, and the sound > code is a big abuser, both ALSA and the legacy OSS code. Yeah, I also started looking at it after reading the LWN article. The removal of set_fs() in ALSA part was already finished, and I'm currently brushing up the patches. It'll be in 4.13 at latest. But the set_fs() usage in OSS code is hard to get rid of, due to the in-kernel ioctl calls, and I really don't want to touch such dusty codes, either. So I wanted to post the very same question, but you were faster :) > But looking at the OSS code it's pretty grotty, and also appears > to be pretty much unmaintained except for global cleanups. Is there > any chance we could look into getting rid of it over the next few > merge windows or are there people that rely on it? I don't think there are any active users. The only slight concern is that there are a few ancient devices that are supported only by some OSS drivers. But these are over decades, and very unlikely alive. That said, I'd love to drop that legacy stuff; or maybe as a soft-landing, begin with disabling the build of sound/oss in Kconfig. The latter can be done even for 4.12, if Linus doesn't mind. thanks, Takashi