From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933486Ab1LFM2G (ORCPT ); Tue, 6 Dec 2011 07:28:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:42418 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933349Ab1LFM2E (ORCPT ); Tue, 6 Dec 2011 07:28:04 -0500 Date: Tue, 06 Dec 2011 13:28:03 +0100 Message-ID: From: Takashi Iwai To: Thomas Meyer Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array In-Reply-To: <1322600880.1534.351.camel@localhost.localdomain> References: <1322600880.1534.351.camel@localhost.localdomain> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 29 Nov 2011 22:08:00 +0100, Thomas Meyer wrote: > > The advantage of kcalloc is, that will prevent integer overflows which could > result from the multiplication of number of elements and size and it is also > a bit nicer to read. > > The semantic patch that makes this change is available > in https://lkml.org/lkml/2011/11/25/107 > > Signed-off-by: Thomas Meyer Thanks, applied both this and asihpi patches. Takashi > --- > > diff -u -p a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c > --- a/sound/pci/ctxfi/ctsrc.c 2011-11-13 11:08:15.090921741 +0100 > +++ b/sound/pci/ctxfi/ctsrc.c 2011-11-28 20:14:46.651112893 +0100 > @@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const s > > /* Allocate mem for master src resource */ > if (MEMRD == desc->mode) > - src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL); > + src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL); > else > src = kzalloc(sizeof(*src), GFP_KERNEL); > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: ctxf: Use kcalloc instead of kzalloc to allocate array Date: Tue, 06 Dec 2011 13:28:03 +0100 Message-ID: References: <1322600880.1534.351.camel@localhost.localdomain> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 734A21039FD for ; Tue, 6 Dec 2011 13:28:03 +0100 (CET) In-Reply-To: <1322600880.1534.351.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Thomas Meyer Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org At Tue, 29 Nov 2011 22:08:00 +0100, Thomas Meyer wrote: > > The advantage of kcalloc is, that will prevent integer overflows which could > result from the multiplication of number of elements and size and it is also > a bit nicer to read. > > The semantic patch that makes this change is available > in https://lkml.org/lkml/2011/11/25/107 > > Signed-off-by: Thomas Meyer Thanks, applied both this and asihpi patches. Takashi > --- > > diff -u -p a/sound/pci/ctxfi/ctsrc.c b/sound/pci/ctxfi/ctsrc.c > --- a/sound/pci/ctxfi/ctsrc.c 2011-11-13 11:08:15.090921741 +0100 > +++ b/sound/pci/ctxfi/ctsrc.c 2011-11-28 20:14:46.651112893 +0100 > @@ -437,7 +437,7 @@ get_src_rsc(struct src_mgr *mgr, const s > > /* Allocate mem for master src resource */ > if (MEMRD == desc->mode) > - src = kzalloc(sizeof(*src)*desc->multi, GFP_KERNEL); > + src = kcalloc(desc->multi, sizeof(*src), GFP_KERNEL); > else > src = kzalloc(sizeof(*src), GFP_KERNEL); > >