Re: [PATCH 3/3] hdsploader: Temporary define for RPM

[Takashi Iwai <tiwai@suse.de>]

At Fri, 29 Jul 2011 07:50:32 +0200,
Takashi Iwai wrote:
> 
> At Thu, 28 Jul 2011 23:45:48 +0200,
> Adrian Knoth wrote:
> > 
> > Right now (1.0.24.1), alsa-lib's hdsp.h doesn't know about the RPM. To
> > avoid a strong dependency on unreleased code, temporary provide the
> > define here.
> > 
> > It can be dropped as soon as a new version of alsa-lib will be released,
> > thus effectively making it the required minimum version for alsa-tools.
> > 
> > Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>
> > 
> > diff --git a/hdsploader/hdsploader.c b/hdsploader/hdsploader.c
> > index fa488a2..bfbe3bc 100644
> > --- a/hdsploader/hdsploader.c
> > +++ b/hdsploader/hdsploader.c
> > @@ -27,6 +27,10 @@
> >  
> >  static u_int32_t code[24413];
> >  
> > +#ifndef RPM
> > +# define RPM	5
> > +#endif
> 
> Now (after committing it), I found that it should be 4 instead of 5...?

Also, the corresponding firmware file isn't found in alsa-firmware tree.
Could you submit it, too?


thanks,

Takashi