From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 933B6C433F5 for ; Sun, 10 Oct 2021 20:25:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F5D960F55 for ; Sun, 10 Oct 2021 20:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232307AbhJJU1L (ORCPT ); Sun, 10 Oct 2021 16:27:11 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:44476 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbhJJU1J (ORCPT ); Sun, 10 Oct 2021 16:27:09 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1A18421FE1; Sun, 10 Oct 2021 20:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633897510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GEQcDzhZ8Ka5CSVQvfxwlWYWOhU/3/GhrODN3V13RPI=; b=u/T4QtmO4zjpWP4G6PpsJYj8evddBVP5dABrjZMZ8CqJbfZUoqzHgHzZlDxk080ekTJTOR FnVqbL2/kEtp1nAvWgB3vmPw6WtaIe54m+Xj94yu8dxg9fQjsG1yUPxVx+R5+HaCXwLwz2 YMIg25qOhHH+4FFj6i8tkiQ55eRU83k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633897510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GEQcDzhZ8Ka5CSVQvfxwlWYWOhU/3/GhrODN3V13RPI=; b=eipG8Doua46nR7vEC1XNGKPBUEGveXX7uStsTSmBb2NhhNFJd9GuLwtCB/FluGSb1yeZgu XcZpQvh5ZrswNlAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id F3877A3B83; Sun, 10 Oct 2021 20:25:09 +0000 (UTC) Date: Sun, 10 Oct 2021 22:25:09 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: allow -EPIPE errors for some v2 messages In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Oct 2021 14:22:41 +0200, Greg Kroah-Hartman wrote: > > The Schiit Hel device does not like to respond to all get_ctl_value_v2() > requests for some reason. This used to work in older kernels, but now > with more strict checking, this failure causes the device to fail to > work. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Signed-off-by: Greg Kroah-Hartman > --- > > This fixes the Shiit Hel device that I have. It used to work on older > kernels (a year ago?), but stopped working for some reason and I didn't > take the time to track it down. This change fixes the issue for me, but > feels wrong for some reason. At least now I can use the device as a > headphone driver, much better than the built-in one for my current > machine... > > If needed, I can take the time to do bisection to track down the real > issue here, it might be due to stricter endpoint checking in the USB > core, but that feels wrong somehow. > > Here's the debugfs USB output for this device, showing the endpoints: > > T: Bus=07 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#= 5 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=30be ProdID=0101 Rev=01.02 > S: Manufacturer=Schiit Audio > S: Product=Schiit Hel > C: #Ifs= 4 Cfg#= 1 Atr=c0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=01(audio) Sub=01 Prot=20 Driver=snd-usb-audio > E: Ad=8f(I) Atr=03(Int.) MxPS= 6 Ivl=1ms > I: If#= 1 Alt= 1 #EPs= 2 Cls=01(audio) Sub=02 Prot=20 Driver=snd-usb-audio > E: Ad=05(O) Atr=05(Isoc) MxPS= 104 Ivl=125us > E: Ad=85(I) Atr=11(Isoc) MxPS= 4 Ivl=1ms > I: If#= 2 Alt= 1 #EPs= 1 Cls=01(audio) Sub=02 Prot=20 Driver=snd-usb-audio > E: Ad=88(I) Atr=05(Isoc) MxPS= 156 Ivl=125us > I: If#= 3 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid > E: Ad=84(I) Atr=03(Int.) MxPS= 16 Ivl=1ms > > Any other suggestions to fix this are welcome. Could you show the exact error messages and lsusb -v output? We may paper over only the problematic node instead. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C473C433EF for ; Sun, 10 Oct 2021 20:26:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFF6160F3A for ; Sun, 10 Oct 2021 20:26:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFF6160F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 54AED1674; Sun, 10 Oct 2021 22:25:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 54AED1674 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633897570; bh=lUXHLM9MzqxMyYU9q2vZJKH+yZYI2yJKrvrnXZiZWBg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZENPxvhPOXstVtgMYQeDQtAYVo2HiJ0DzmBM0O7KRg3XQ90umyakWzdix1+6qeCXW GDhP3uU4ZgHzewe31MiU/HkwpT1pogifhfwAtCyhCBqMfntxHH7CTQX0xWu/ZX5nsD NNYSPkdQ6asRZN05vpM+MbCr4KIDTSahB1Zt+QTA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CFBA4F8016D; Sun, 10 Oct 2021 22:25:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B06AF801F7; Sun, 10 Oct 2021 22:25:18 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C1AECF8016D for ; Sun, 10 Oct 2021 22:25:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C1AECF8016D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="u/T4QtmO"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="eipG8Dou" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1A18421FE1; Sun, 10 Oct 2021 20:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633897510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GEQcDzhZ8Ka5CSVQvfxwlWYWOhU/3/GhrODN3V13RPI=; b=u/T4QtmO4zjpWP4G6PpsJYj8evddBVP5dABrjZMZ8CqJbfZUoqzHgHzZlDxk080ekTJTOR FnVqbL2/kEtp1nAvWgB3vmPw6WtaIe54m+Xj94yu8dxg9fQjsG1yUPxVx+R5+HaCXwLwz2 YMIg25qOhHH+4FFj6i8tkiQ55eRU83k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633897510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GEQcDzhZ8Ka5CSVQvfxwlWYWOhU/3/GhrODN3V13RPI=; b=eipG8Doua46nR7vEC1XNGKPBUEGveXX7uStsTSmBb2NhhNFJd9GuLwtCB/FluGSb1yeZgu XcZpQvh5ZrswNlAg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id F3877A3B83; Sun, 10 Oct 2021 20:25:09 +0000 (UTC) Date: Sun, 10 Oct 2021 22:25:09 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Subject: Re: [PATCH] ALSA: usb-audio: allow -EPIPE errors for some v2 messages In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 10 Oct 2021 14:22:41 +0200, Greg Kroah-Hartman wrote: > > The Schiit Hel device does not like to respond to all get_ctl_value_v2() > requests for some reason. This used to work in older kernels, but now > with more strict checking, this failure causes the device to fail to > work. > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Signed-off-by: Greg Kroah-Hartman > --- > > This fixes the Shiit Hel device that I have. It used to work on older > kernels (a year ago?), but stopped working for some reason and I didn't > take the time to track it down. This change fixes the issue for me, but > feels wrong for some reason. At least now I can use the device as a > headphone driver, much better than the built-in one for my current > machine... > > If needed, I can take the time to do bisection to track down the real > issue here, it might be due to stricter endpoint checking in the USB > core, but that feels wrong somehow. > > Here's the debugfs USB output for this device, showing the endpoints: > > T: Bus=07 Lev=02 Prnt=02 Port=01 Cnt=01 Dev#= 5 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=30be ProdID=0101 Rev=01.02 > S: Manufacturer=Schiit Audio > S: Product=Schiit Hel > C: #Ifs= 4 Cfg#= 1 Atr=c0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 1 Cls=01(audio) Sub=01 Prot=20 Driver=snd-usb-audio > E: Ad=8f(I) Atr=03(Int.) MxPS= 6 Ivl=1ms > I: If#= 1 Alt= 1 #EPs= 2 Cls=01(audio) Sub=02 Prot=20 Driver=snd-usb-audio > E: Ad=05(O) Atr=05(Isoc) MxPS= 104 Ivl=125us > E: Ad=85(I) Atr=11(Isoc) MxPS= 4 Ivl=1ms > I: If#= 2 Alt= 1 #EPs= 1 Cls=01(audio) Sub=02 Prot=20 Driver=snd-usb-audio > E: Ad=88(I) Atr=05(Isoc) MxPS= 156 Ivl=125us > I: If#= 3 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=00 Prot=00 Driver=usbhid > E: Ad=84(I) Atr=03(Int.) MxPS= 16 Ivl=1ms > > Any other suggestions to fix this are welcome. Could you show the exact error messages and lsusb -v output? We may paper over only the problematic node instead. thanks, Takashi