From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9373CC433DB for ; Tue, 9 Mar 2021 06:37:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C1586529C for ; Tue, 9 Mar 2021 06:37:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbhCIGhX (ORCPT ); Tue, 9 Mar 2021 01:37:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:57278 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbhCIGhC (ORCPT ); Tue, 9 Mar 2021 01:37:02 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74D72AC1F; Tue, 9 Mar 2021 06:37:01 +0000 (UTC) Date: Tue, 09 Mar 2021 07:37:01 +0100 Message-ID: From: Takashi Iwai To: Pavel Skripkin Cc: perex@perex.cz, tiwai@suse.com, kai.heng.feng@canonical.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, syzbot+719da9b149a931f5143f@syzkaller.appspotmail.com Subject: Re: [PATCH next 1/2] sound: usb: fix NULL ptr dereference in usb_audio_probe In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 Mar 2021 23:30:36 +0100, Pavel Skripkin wrote: > > syzbot reported null pointer dereference in usb_audio_probe. > The problem was in case, when quirk == NULL. It's not an > error condition, so quirk must be checked before dereferencing. > > Call Trace: > usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:396 > really_probe+0x291/0xe60 drivers/base/dd.c:554 > driver_probe_device+0x26b/0x3d0 drivers/base/dd.c:740 > __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:846 > bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 > __device_attach+0x228/0x4a0 drivers/base/dd.c:914 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 > device_add+0xbdb/0x1db0 drivers/base/core.c:3242 > usb_set_configuration+0x113f/0x1910 drivers/usb/core/message.c:2164 > usb_generic_driver_probe+0xba/0x100 drivers/usb/core/generic.c:238 > usb_probe_device+0xd9/0x2c0 drivers/usb/core/driver.c:293 > really_probe+0x291/0xe60 drivers/base/dd.c:554 > driver_probe_device+0x26b/0x3d0 drivers/base/dd.c:740 > __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:846 > bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 > __device_attach+0x228/0x4a0 drivers/base/dd.c:914 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 > device_add+0xbdb/0x1db0 drivers/base/core.c:3242 > usb_new_device.cold+0x721/0x1058 drivers/usb/core/hub.c:2555 > hub_port_connect drivers/usb/core/hub.c:5223 [inline] > hub_port_connect_change drivers/usb/core/hub.c:5363 [inline] > port_event drivers/usb/core/hub.c:5509 [inline] > hub_event+0x2357/0x4320 drivers/usb/core/hub.c:5591 > process_one_work+0x98d/0x1600 kernel/workqueue.c:2275 > worker_thread+0x64c/0x1120 kernel/workqueue.c:2421 > kthread+0x3b1/0x4a0 kernel/kthread.c:292 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 > > Reported-by: syzbot+719da9b149a931f5143f@syzkaller.appspotmail.com > Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()") > Signed-off-by: Pavel Skripkin Thanks, applied now. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF87C433DB for ; Tue, 9 Mar 2021 06:38:04 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E9A065295 for ; Tue, 9 Mar 2021 06:38:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E9A065295 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 22D8B1735; Tue, 9 Mar 2021 07:37:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 22D8B1735 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1615271881; bh=rrKxLL1CJCDTD8znEq3dm4PFro0umXGZSNA5t6YLS/k=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nKMtagxW4LiuK76OzMhCHckfFIS1T9qlQkGsAy2G/azGAQ5Yqh6m5YuTtedVYcQWM /nWfUFgIvKf/XvV6ynYy2JAFbBv8rGfpR7kVuTB3o2yRwhRsAboLp537/rGJfp0KLA QMWUKCyQhNIBv/JvQDLuIuC/GYyuCLeTJYgAqMlU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 677A7F8019B; Tue, 9 Mar 2021 07:37:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 79C41F80227; Tue, 9 Mar 2021 07:37:08 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C8E52F80166 for ; Tue, 9 Mar 2021 07:37:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C8E52F80166 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 74D72AC1F; Tue, 9 Mar 2021 06:37:01 +0000 (UTC) Date: Tue, 09 Mar 2021 07:37:01 +0100 Message-ID: From: Takashi Iwai To: Pavel Skripkin Subject: Re: [PATCH next 1/2] sound: usb: fix NULL ptr dereference in usb_audio_probe In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, syzbot+719da9b149a931f5143f@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, kai.heng.feng@canonical.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 08 Mar 2021 23:30:36 +0100, Pavel Skripkin wrote: > > syzbot reported null pointer dereference in usb_audio_probe. > The problem was in case, when quirk == NULL. It's not an > error condition, so quirk must be checked before dereferencing. > > Call Trace: > usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:396 > really_probe+0x291/0xe60 drivers/base/dd.c:554 > driver_probe_device+0x26b/0x3d0 drivers/base/dd.c:740 > __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:846 > bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 > __device_attach+0x228/0x4a0 drivers/base/dd.c:914 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 > device_add+0xbdb/0x1db0 drivers/base/core.c:3242 > usb_set_configuration+0x113f/0x1910 drivers/usb/core/message.c:2164 > usb_generic_driver_probe+0xba/0x100 drivers/usb/core/generic.c:238 > usb_probe_device+0xd9/0x2c0 drivers/usb/core/driver.c:293 > really_probe+0x291/0xe60 drivers/base/dd.c:554 > driver_probe_device+0x26b/0x3d0 drivers/base/dd.c:740 > __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:846 > bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 > __device_attach+0x228/0x4a0 drivers/base/dd.c:914 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 > device_add+0xbdb/0x1db0 drivers/base/core.c:3242 > usb_new_device.cold+0x721/0x1058 drivers/usb/core/hub.c:2555 > hub_port_connect drivers/usb/core/hub.c:5223 [inline] > hub_port_connect_change drivers/usb/core/hub.c:5363 [inline] > port_event drivers/usb/core/hub.c:5509 [inline] > hub_event+0x2357/0x4320 drivers/usb/core/hub.c:5591 > process_one_work+0x98d/0x1600 kernel/workqueue.c:2275 > worker_thread+0x64c/0x1120 kernel/workqueue.c:2421 > kthread+0x3b1/0x4a0 kernel/kthread.c:292 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 > > Reported-by: syzbot+719da9b149a931f5143f@syzkaller.appspotmail.com > Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()") > Signed-off-by: Pavel Skripkin Thanks, applied now. Takashi