From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762749AbdKRQtu (ORCPT ); Sat, 18 Nov 2017 11:49:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:51027 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762254AbdKRQtk (ORCPT ); Sat, 18 Nov 2017 11:49:40 -0500 Date: Sat, 18 Nov 2017 17:49:38 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, broonie@kernel.org, torvalds@linux-foundation.org, vinod.koul@intel.com, liam.r.girdwood@linux.intel.com, andriy.shevchenko@linux.intel.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig In-Reply-To: <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Nov 2017 01:01:56 +0100, Pierre-Louis Bossart wrote: > > +if SND_SOC_INTEL_BAYTRAIL > > config SND_SOC_INTEL_BYT_MAX98090_MACH > tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" > + default n default=n is superfluous, can be dropped. > depends on X86_INTEL_LPSS && I2C > - depends on SND_SST_IPC_ACPI = n > - depends on SND_SOC_INTEL_BAYTRAIL > select SND_SOC_MAX98090 So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I guess this will allow this machine driver built although it shouldn't be? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [RFC PATCH 1/7] ASoC: Intel: Fix Kconfig Date: Sat, 18 Nov 2017 17:49:38 +0100 Message-ID: References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 159B8266F1C for ; Sat, 18 Nov 2017 17:49:40 +0100 (CET) In-Reply-To: <20171118000202.22302-2-pierre-louis.bossart@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, arnd@arndb.de, vinod.koul@intel.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org List-Id: alsa-devel@alsa-project.org On Sat, 18 Nov 2017 01:01:56 +0100, Pierre-Louis Bossart wrote: > > +if SND_SOC_INTEL_BAYTRAIL > > config SND_SOC_INTEL_BYT_MAX98090_MACH > tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec" > + default n default=n is superfluous, can be dropped. > depends on X86_INTEL_LPSS && I2C > - depends on SND_SST_IPC_ACPI = n > - depends on SND_SOC_INTEL_BAYTRAIL > select SND_SOC_MAX98090 So the dependency on ND_SST_IPC_ACPI=n is removed here too, and I guess this will allow this machine driver built although it shouldn't be? thanks, Takashi