From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2 8/9] ALSA: line6: Cleanup initialization
Date: Wed, 24 Aug 2016 17:06:25 +0200
Message-ID: <s5hinuq2olq.wl-tiwai@suse.de>
References: <1470942147-19848-1-git-send-email-dev@andree.sk>
 <1471558839-14120-1-git-send-email-dev@andree.sk>
 <1471558839-14120-9-git-send-email-dev@andree.sk>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 7735C26A20B
 for <alsa-devel@alsa-project.org>; Wed, 24 Aug 2016 17:06:25 +0200 (CEST)
In-Reply-To: <1471558839-14120-9-git-send-email-dev@andree.sk>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Andrej Krutak <dev@andree.sk>
Cc: stefanha@gmail.com, alsa-devel@alsa-project.org, grabner@icg.tugraz.at
List-Id: alsa-devel@alsa-project.org

On Fri, 19 Aug 2016 00:20:38 +0200,
Andrej Krutak wrote:
> 
> Only determine control port properties if the devices needs it.
> Only initialize PCM for POD HD devices that support it.
> No POD HD seems to support MIDI, thus drop the initialization.

This should be split to two individual patches.  They are irrelevant
with each other at all.


Takashi

> 
> Signed-off-by: Andrej Krutak <dev@andree.sk>
> ---
>  sound/usb/line6/driver.c |  3 +--
>  sound/usb/line6/podhd.c  | 19 ++++++++-----------
>  2 files changed, 9 insertions(+), 13 deletions(-)
> 
> diff --git a/sound/usb/line6/driver.c b/sound/usb/line6/driver.c
> index 853a143..8a71d45 100644
> --- a/sound/usb/line6/driver.c
> +++ b/sound/usb/line6/driver.c
> @@ -612,9 +612,8 @@ int line6_probe(struct usb_interface *interface,
>  		goto error;
>  	}
>  
> -	line6_get_interval(line6);
> -
>  	if (properties->capabilities & LINE6_CAP_CONTROL) {
> +		line6_get_interval(line6);
>  		ret = line6_init_cap_control(line6);
>  		if (ret < 0)
>  			goto error;
> diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
> index 8246ea5..193eb29 100644
> --- a/sound/usb/line6/podhd.c
> +++ b/sound/usb/line6/podhd.c
> @@ -314,17 +314,14 @@ static int podhd_init(struct usb_line6 *line6,
>  			return err;
>  	}
>  
> -	/* initialize MIDI subsystem: */
> -	err = line6_init_midi(line6);
> -	if (err < 0)
> -		return err;
> -
> -	/* initialize PCM subsystem: */
> -	err = line6_init_pcm(line6,
> -		(id->driver_info == LINE6_PODX3) ? &podx3_pcm_properties :
> -		&podhd_pcm_properties);
> -	if (err < 0)
> -		return err;
> +	if (pod->line6.properties->capabilities & LINE6_CAP_PCM) {
> +		/* initialize PCM subsystem: */
> +		err = line6_init_pcm(line6,
> +			(id->driver_info == LINE6_PODX3) ? &podx3_pcm_properties :
> +			&podhd_pcm_properties);
> +		if (err < 0)
> +			return err;
> +	}
>  
>  	if (!(pod->line6.properties->capabilities & LINE6_CAP_CONTROL)) {
>  		/* register USB audio system directly */
> -- 
> 1.9.1
> 
>