From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 08/16] ALSA: line6: Drop superfluous spinlock for trigger Date: Tue, 27 Jan 2015 17:10:15 +0100 Message-ID: References: <1422033203-23254-1-git-send-email-tiwai@suse.de> <1422033203-23254-9-git-send-email-tiwai@suse.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id AF9352608BC for ; Tue, 27 Jan 2015 17:10:19 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Chris Rorvick Cc: Stefan Hajnoczi , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Tue, 27 Jan 2015 06:48:22 -0600, Chris Rorvick wrote: > > On Tue, Jan 27, 2015 at 4:27 AM, Takashi Iwai wrote: > > At Tue, 27 Jan 2015 00:22:48 -0600, Chris Rorvick wrote: > >> All of this looks racy to me. Am I missing something? > > > > Yes, the code *is* already racy :) > > OK, good to know I'm not seeing ghosts. :-) Hehe. I wrote a few more patches to cover the races in a bit better way (although it's not perfect yet). I'm going to send to ML soon. Could you give tested-by tag if the latest test/line6 branch works -- at least, no serious regression is seen? thanks, Takashi