From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: HD-audio regression after commit 34588709af61be1550b4e2bcee5c85d0ac4f34d4 Date: Sat, 19 Jan 2013 12:09:17 +0100 Message-ID: References: <20130117191224.44794728@gmail.com> <20130117214043.5a1574ee@gmail.com> <20130118090839.4a0725f8@gmail.com> <20130118133753.3eabbb18@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 5B179265125 for ; Sat, 19 Jan 2013 12:09:17 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Raymond Yau Cc: basinilya@gmail.com, Manolo =?UTF-8?B?RMOtYXo=?= , alsa-devel@alsa-project.org, Miro Hodak List-Id: alsa-devel@alsa-project.org At Sat, 19 Jan 2013 10:39:39 +0800, Raymond Yau wrote: > > [1 ] > > > > > > > > It's already in the repository. Now none of the input sources work > for > > > > > me: front-mic, rear-mic nor input line. Alsa-info output is > attached. > > > > > > > > > > commit 77ecb70ef5b022a1ee80169583753d85d7a9c396 > > > > > > > > Hmm, through a quick glance, all look OK. > > > > > > > > > > It is strange that three input source are line but audio selector are > not > > > the same > > > > > > Simple mixer control 'Input Source',0 > > > Capabilities: cenum > > > Items: 'Front Mic' 'Rear Mic' 'Line' 'CD' > > > Item0: 'Line' > > > Simple mixer control 'Input Source',1 > > > Capabilities: cenum > > > Items: 'Front Mic' 'Rear Mic' 'Line' 'CD' > > > Item0: 'Line' > > > Simple mixer control 'Input Source',2 > > > Capabilities: cenum > > > Items: 'Front Mic' 'Rear Mic' 'Line' 'CD' > > > Item0: 'Line' > > > > > > Node 0x0c [Audio Selector] wcaps 0x30010d: Stereo Amp-Out > > > Control: name="Capture Volume", index=0, device=0 > > > ControlAmp: chs=3, dir=Out, idx=0, ofs=0 > > > Control: name="Capture Switch", index=0, device=0 > > > ControlAmp: chs=3, dir=Out, idx=0, ofs=0 > > > Amp-Out caps: ofs=0x27, nsteps=0x36, stepsize=0x05, mute=1 > > > Amp-Out vals: [0x36 0x36] > > > Connection: 11 > > > 0x38 0x39 0x3a* 0x3b 0x3c 0x18 0x24 0x25 0x3d 0x20 0x1f > > > Node 0x0d [Audio Selector] wcaps 0x30010d: Stereo Amp-Out > > > Control: name="Capture Volume", index=1, device=0 > > > ControlAmp: chs=3, dir=Out, idx=0, ofs=0 > > > Control: name="Capture Switch", index=1, device=0 > > > ControlAmp: chs=3, dir=Out, idx=0, ofs=0 > > > Amp-Out caps: ofs=0x27, nsteps=0x36, stepsize=0x05, mute=1 > > > Amp-Out vals: [0x36 0x36] > > > Connection: 10 > > > 0x38 0x39* 0x3a 0x3b 0x3c 0x18 0x24 0x25 0x3d 0x20 > > > Node 0x0e [Audio Selector] wcaps 0x30010d: Stereo Amp-Out > > > Control: name="Capture Volume", index=2, device=0 > > > ControlAmp: chs=3, dir=Out, idx=0, ofs=0 > > > Control: name="Capture Switch", index=2, device=0 > > > ControlAmp: chs=3, dir=Out, idx=0, ofs=0 > > > Amp-Out caps: ofs=0x27, nsteps=0x36, stepsize=0x05, mute=1 > > > Amp-Out vals: [0x36 0x36] > > > Connection: 10 > > > 0x38 0x39* 0x3a 0x3b 0x3c 0x18 0x24 0x25 0x3d 0x20 > > > > Good catch. It's a recent regression. > > I fixed now with the patch below. > > > > test/hda-gen-parser and master branches are updated now with this and > > other fixes. > > > > > > > thanks, > > > > Takashi > > > > --- > > From: Takashi Iwai > > Subject: [PATCH] ALSA: hda - Fix the wrong adc_idx for capture source > > > > The patch "ALSA: hda - fix wrong adc_idx in generic parser" fixed the > > adc_idx for the capture volume and capture switch controls. But also > > modified the adc_idx retrieval for the capture source controls > > wrongly. As multiple capture source controls are created in a single > > shot with counts > 1, the id.index doesn't contain the real value. > > The real index has to be taken via snd_ctl_get_ioffidx() as in the > > original code. > > > > This patch reverts the fixes partially to recover from the > > regression. > > > Refer to commit > > http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-unstable.git;a=commit;h=1c70a583417e8db1e1d5069d7651ba294e9499de > > Do you mean user have to specify hint > > 1) mixer_nid to analog the aa-path for creating those Mic/line playback > volume/switch ? mixer_nid should be set in each caller, i.e. patch_ad1988(). It's just missing there. Of course, you can set it explicitly via a hint string by yourself later. > 2) add_stereo_mix_input for the missing input source "mix" This also depends on the codec and preference. I guess it'd make sense to enable it as default for AD1988x. Takashi