All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Omari Stephens <xsdg@xsdg.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] New quirk for USB DAC 08bb:2704
Date: Mon, 14 Feb 2011 23:32:48 +0100	[thread overview]
Message-ID: <s5hipwm6ycv.wl%tiwai@suse.de> (raw)
In-Reply-To: <4D599BA2.3040105@xsdg.org>

At Mon, 14 Feb 2011 21:16:18 +0000,
Omari Stephens wrote:
> 
> On 02/14/2011 05:10 PM, Takashi Iwai wrote:
> > At Sat, 12 Feb 2011 22:53:25 +0000,
> > Omari Stephens wrote:
> >>
> >> Howdy, all
> >>
> >> I have one of these:
> >> http://www.chordelectronics.co.uk/products_detail.asp?id=63
> >>
> >> It's got one of these USB DACs inside
> >> ID 08bb:2704 Texas Instruments Japan
> >>
> >> The DAC has a single mixer control, Master, which allows you to adjust
> >> volume and mute/unmute.  The fun thing is that the volume adjustment has
> >> no effect whatsoever.  On machines running pulse, this means that output
> >> will be at 0dB pretty much all the time.  (Of course, this is true of
> >> non-pulse machines also).
> >>
> >> The attached patch disables the Master control, which causes pulse to
> >> control levels entirely in software, as it should for this device.
> >>
> >> The main downside to this patch is that, while the volume part of the
> >> Master control is non-functional, the mute/unmute aspect does work as
> >> expected.  I couldn't figure out how to change the Master control to
> >> just a mute/unmute control, but if someone has suggestions on what to
> >> do, that'd be appreciated.  Judging by the comments in the code (and
> >> contrary to what I wrote in the map comment), I presume the mute/unmute
> >> control is the only reason why 08bb:2702 isn't doing this same thing.
> >
> > The patch looks good to me.  Could you give your sign-off?
> Oops; sorry (haven't submitted a kernel patch before).  Will do.
> 
> That said, I have some friends with the same device, and at least one 
> says that the volume control works fine for him, so I want to do a bit 
> more investigation before this quirk gets added.  Will send email when I 
> get things figured out a little more.

OK, let me know if it's ready.


thanks,

Takashi

      reply	other threads:[~2011-02-14 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-12 22:53 [PATCH] New quirk for USB DAC 08bb:2704 Omari Stephens
2011-02-14 17:10 ` Takashi Iwai
2011-02-14 21:16   ` Omari Stephens
2011-02-14 22:32     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hipwm6ycv.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=xsdg@xsdg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.