All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Karl Beldan <karl.beldan@gmail.com>,
	uclinux-dist-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, Cliff Cai <cliff.cai@analog.com>,
	Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [Uclinux-dist-devel] [PATCH 2/5] ASoC	codec:	SSM2602: assign last substream to the master when	shutting down
Date: Sun, 14 Jun 2009 10:15:41 +0200	[thread overview]
Message-ID: <s5hiqiztemq.wl%tiwai@suse.de> (raw)
In-Reply-To: <20090613110607.GA8052@opensource.wolfsonmicro.com>

At Sat, 13 Jun 2009 12:06:07 +0100,
Mark Brown wrote:
> 
> On Sat, Jun 13, 2009 at 07:03:12AM -0400, Mike Frysinger wrote:
> 
> > the first part conditionalized the constraints.  ignoring whitespace
> > changes, this is the diff:
> > +if (master_runtime->rate != 0)
> >     snd_pcm_hw_constraint_minmax(substream->runtime,
> >     ......
> > +if (master_runtime->sample_bits != 0)
> >     snd_pcm_hw_constraint_minmax(substream->runtime,
> >     ......
> 
> > or maybe that is what you're saying and i dont know alsa
> 
> That's not a bad change - there's a thin race condition if you
> simultaneously start up two applications where the primary substream
> could be there but not yet configured since stream startup is separate
> to the configuration of the stream.  It's hard but not impossible to
> reproduce.

An absolute race-free hw-constraint for multiple substreams is
actually difficult to implement.  The best practice would be to give
an error and refuse the change when any inconsistency occurs, IMO.


Takashi

  reply	other threads:[~2009-06-14  8:15 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02  4:18 [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Mike Frysinger
2009-06-02  4:18 ` [PATCH 2/5] ASoC codec: SSM2602: assign last substream to the master when shutting down Mike Frysinger
2009-06-03 10:52   ` Mark Brown
2009-06-03 12:37     ` [Uclinux-dist-devel] " Mike Frysinger
2009-06-03 14:53       ` Mark Brown
2009-06-04  1:26         ` Mike Frysinger
2009-06-04  8:17           ` Karl Beldan
2009-06-04  8:22             ` Mike Frysinger
2009-06-04  8:31               ` Cai, Cliff
2009-06-04  8:45                 ` Mike Frysinger
2009-06-04  8:56                   ` Cai, Cliff
2009-06-04  9:37                     ` Karl Beldan
2009-06-04  8:40               ` Karl Beldan
2009-06-04  8:50                 ` Cai, Cliff
2009-06-04  8:55                   ` Mike Frysinger
2009-06-04  8:59           ` Mark Brown
2009-06-04  9:04             ` Mike Frysinger
2009-06-13  9:37             ` Karl Beldan
2009-06-13 10:10               ` Mike Frysinger
2009-06-13 10:44               ` Mark Brown
2009-06-13 10:47                 ` Mike Frysinger
2009-06-13 10:59                   ` Mark Brown
2009-06-13 11:03                     ` Mike Frysinger
2009-06-13 11:06                       ` Mark Brown
2009-06-14  8:15                         ` Takashi Iwai [this message]
2009-06-15  2:40                           ` Cai, Cliff
2009-06-02  4:18 ` [PATCH 3/5] ASoC: Blackfin: tweak how we initialize the SPORT Mike Frysinger
2009-06-03 10:29   ` Mark Brown
2009-06-04  2:36     ` [PATCH 3/5] ASoC: Blackfin: tweak how weinitialize " Cai, Cliff
2009-06-04 10:51       ` Mark Brown
2009-06-08  2:14         ` [PATCH 3/5] ASoC: Blackfin: tweak howweinitialize " Cai, Cliff
2009-06-20 15:29           ` [PATCH] ASoC: Blackfin: keep better track of SPORT configuration state Mike Frysinger
2009-06-20 18:41             ` Mark Brown
2009-06-02  4:18 ` [PATCH 4/5] ASoC: Blackfin: set the transfer size according the ac97_frame size Mike Frysinger
2009-06-03 10:30   ` Mark Brown
2009-06-02  4:18 ` [PATCH 5/5] ASoC: Blackfin: document how anomaly 05000250 is handled Mike Frysinger
2009-06-03 10:30   ` Mark Brown
2009-06-03 10:26 ` [PATCH 1/5] ASoC codec: SSM2602: remove unsupported sample rates Mark Brown
2009-06-03 12:11   ` Karl Beldan
2009-06-03 12:15     ` Mark Brown
2009-06-03 12:42       ` Karl Beldan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hiqiztemq.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cliff.cai@analog.com \
    --cc=karl.beldan@gmail.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.