From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96002C433EF for ; Tue, 12 Oct 2021 09:04:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A12B61050 for ; Tue, 12 Oct 2021 09:04:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235229AbhJLJGd (ORCPT ); Tue, 12 Oct 2021 05:06:33 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:53492 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232578AbhJLJGb (ORCPT ); Tue, 12 Oct 2021 05:06:31 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4F83E20189; Tue, 12 Oct 2021 09:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634029469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+Vnu+dGJvhslOcjX53sAtUXL7sz0psnYar7lzgEPKQ=; b=yoSfayA5O1BqV91h2E9/8cZJI0cVPjBR/g0mWBPiqJVt4UoXrZUJyzjh1vCLUrHJqCN3jN M53UdLvAxC41ineH1LTR6vkNw2INsfLJiUQ0q+kn63lfI8s35yKxXckfisf0i8LiUTxKuU PrT+tX9Q9FhBQ7ykoAcNFWOZXRuMmUM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634029469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+Vnu+dGJvhslOcjX53sAtUXL7sz0psnYar7lzgEPKQ=; b=2SG6+XG+d/7HNHDj3pPjzqCL7dafXvbUiEF8N5+fUQXqEWCc+ZbVe4Y2YipD3ZDXlQ7l6l RM8bT7XbhbbBIfCw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 4154BA3B8A; Tue, 12 Oct 2021 09:04:29 +0000 (UTC) Date: Tue, 12 Oct 2021 11:04:29 +0200 Message-ID: From: Takashi Iwai To: Jonas Hahnfeld Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770 In-Reply-To: <27189cfac466b244e176f3098409204fc67a2a8d.camel@hahnjo.de> References: <20211010111947.5796-1-hahnjo@hahnjo.de> <27189cfac466b244e176f3098409204fc67a2a8d.camel@hahnjo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Oct 2021 19:12:56 +0200, Jonas Hahnfeld wrote: > > Am Sonntag, dem 10.10.2021 um 22:26 +0200 schrieb Takashi Iwai: > > On Sun, 10 Oct 2021 13:19:47 +0200, > > Jonas Hahnfeld wrote: > > > > > > The device advertises 8 formats, but only a rate of 48kHz is honored > > > by the hardware and 24 bits give chopped audio, so only report the > > > one working combination. This fixes out-of-the-box audio experience > > > with PipeWire which otherwise attempts to choose S24_3LE (while > > > PulseAudio defaulted to S16_LE). > > > > > > Signed-off-by: Jonas Hahnfeld > > > > Could you give alsa-info.sh output with and without patch, just for > > comparison? Run the script with --no-upload option and attach the > > outputs. > > Attached. Let me know if I should put any of this into the commit > message. Thanks. The device is a UAC1, so the format quirk seems to be a valid way. But I found the terminator entry (.ifnum = -1) is missing in the QUIRK_COMPOSITE array. Could you resubmit with the fix? thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA0EC433F5 for ; Tue, 12 Oct 2021 09:06:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FD3C61056 for ; Tue, 12 Oct 2021 09:06:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FD3C61056 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 444031695; Tue, 12 Oct 2021 11:05:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 444031695 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1634029580; bh=k1GasGFdlPVQy+5/sThmkczvdQWP26az2aVntqsTziE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bfBX6Ma1hNKUiVspsP71v7lBITag9sWSS5JPrKMgOenzLQbgiBi2txZOzkyagr62+ hVNG775jAzoeYOmYdV/8IX3zFaxxn48JiOXZMSYI+yqbAwn7LA+K1wBQbsjMYQ31xm Pxhjplev2BeDl4pmS6/EMhDXLfiUL2+1d+L7JARg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 35AD4F804E5; Tue, 12 Oct 2021 11:04:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF956F80088; Tue, 12 Oct 2021 11:04:39 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5820FF80088 for ; Tue, 12 Oct 2021 11:04:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5820FF80088 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yoSfayA5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="2SG6+XG+" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 4F83E20189; Tue, 12 Oct 2021 09:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634029469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+Vnu+dGJvhslOcjX53sAtUXL7sz0psnYar7lzgEPKQ=; b=yoSfayA5O1BqV91h2E9/8cZJI0cVPjBR/g0mWBPiqJVt4UoXrZUJyzjh1vCLUrHJqCN3jN M53UdLvAxC41ineH1LTR6vkNw2INsfLJiUQ0q+kn63lfI8s35yKxXckfisf0i8LiUTxKuU PrT+tX9Q9FhBQ7ykoAcNFWOZXRuMmUM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634029469; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L+Vnu+dGJvhslOcjX53sAtUXL7sz0psnYar7lzgEPKQ=; b=2SG6+XG+d/7HNHDj3pPjzqCL7dafXvbUiEF8N5+fUQXqEWCc+ZbVe4Y2YipD3ZDXlQ7l6l RM8bT7XbhbbBIfCw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 4154BA3B8A; Tue, 12 Oct 2021 09:04:29 +0000 (UTC) Date: Tue, 12 Oct 2021 11:04:29 +0200 Message-ID: From: Takashi Iwai To: Jonas Hahnfeld Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for VF0770 In-Reply-To: <27189cfac466b244e176f3098409204fc67a2a8d.camel@hahnjo.de> References: <20211010111947.5796-1-hahnjo@hahnjo.de> <27189cfac466b244e176f3098409204fc67a2a8d.camel@hahnjo.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 11 Oct 2021 19:12:56 +0200, Jonas Hahnfeld wrote: > > Am Sonntag, dem 10.10.2021 um 22:26 +0200 schrieb Takashi Iwai: > > On Sun, 10 Oct 2021 13:19:47 +0200, > > Jonas Hahnfeld wrote: > > > > > > The device advertises 8 formats, but only a rate of 48kHz is honored > > > by the hardware and 24 bits give chopped audio, so only report the > > > one working combination. This fixes out-of-the-box audio experience > > > with PipeWire which otherwise attempts to choose S24_3LE (while > > > PulseAudio defaulted to S16_LE). > > > > > > Signed-off-by: Jonas Hahnfeld > > > > Could you give alsa-info.sh output with and without patch, just for > > comparison? Run the script with --no-upload option and attach the > > outputs. > > Attached. Let me know if I should put any of this into the commit > message. Thanks. The device is a UAC1, so the format quirk seems to be a valid way. But I found the terminator entry (.ifnum = -1) is missing in the QUIRK_COMPOSITE array. Could you resubmit with the fix? thanks, Takashi