From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB53C38A2A for ; Sun, 10 May 2020 17:29:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4F3F208DB for ; Sun, 10 May 2020 17:29:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="tDB10kut" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4F3F208DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2021E86F; Sun, 10 May 2020 19:28:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2021E86F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589131771; bh=cCBtTt3HjpVVU7wrsWcNPl54f6i++AosVhdlbpWEK6o=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tDB10kutUEf1P8Rq6xqLDBH56/pVKWhJEK4NghM+7cA0B0diS/J22MgbhchFILGwK d1cajMa7IyWDHqwLNJdzDUm+poLtehCTAfza6eKq9OII0TfFYJApPAE5Av+HIpfjL2 8ALlyXuMgk+rkOUQElFF1T434mnHCkJRnlHpMo40= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7B690F80148; Sun, 10 May 2020 19:28:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 613ABF80158; Sun, 10 May 2020 19:28:33 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 221FEF800BF for ; Sun, 10 May 2020 19:28:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 221FEF800BF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 560AFAE2C; Sun, 10 May 2020 17:28:29 +0000 (UTC) Date: Sun, 10 May 2020 19:28:25 +0200 Message-ID: From: Takashi Iwai To: Takashi Sakamoto Subject: Re: [PATCH 0/6] ALSA: fireface: add support for Fireface 802 and UFX In-Reply-To: <20200510101741.GA118827@workstation> References: <20200510074301.116224-1-o-takashi@sakamocchi.jp> <20200510101741.GA118827@workstation> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: ffado-devel@lists.sourceforge.net, alsa-devel@alsa-project.org, clemens@ladisch.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, 10 May 2020 12:17:41 +0200, Takashi Sakamoto wrote: > > Hi, > > On Sun, May 10, 2020 at 12:05:58PM +0200, Takashi Iwai wrote: > > On Sun, 10 May 2020 09:42:55 +0200, > > Takashi Sakamoto wrote: > > > > > > Hi, > > > > > > Fireface 802 was shipped by RME GmbH in 2014. This model is one of latter > > > models of Fireface series and support both of IEEE 1394 bus and USB. > > > Furthermore, it supports two types of remote control unit (Basic > > > Remote and Advanced Remote Control) with by 9pin mini-din connector. > > > > > > This patchset adds support for this model as a part of devices available > > > by ALSA firewire stack (therefore it's not a device of USB). Userspace > > > applications can transfer PCM frames and MIDI messages via ALSA PCM > > > and Rawmidi interfaces. > > > > > > Fireface UFX is also supported since its internal design is almost the > > > same as Fireface 802 in a point of packet communication. The support is > > > untested and the status is 'request for test'. > > > > > > As well as the other models of RME Fireface series, audio output > > > includes periodical hissing noise. This is not solved yet. > > > > > > Furthermore, capture of MIDI messages requires assist of userspace > > > application. For the detail, please read comment in > > > 'sound/firewire/fireface/ff-protocol-latter.c'. > > > > > > Regards > > > > > > Takashi Sakamoto (6): > > > ALSA: fireface: fix configuration error for nominal sampling transfer > > > frequency > > > ALSA: fireface: start IR context immediately > > > ALSA: fireface: code refactoring to add enumeration constants for > > > model identification > > > ALSA: fireface: code refactoring for name of sound card > > > ALSA: fireface: add support for RME FireFace 802 > > > ALSA: fireface: add support for Fireface UFX (untested) > > > > Would you like me merging the patches although at least one of them is > > marked untested? The code changes look reasonable, so I have no > > problem to applying patches themselves to 5.8 branch. > > I'd like you to apply them. > > For development I have a theory that untested code should not be merged > (yep, as much as possible). However, in the case, I judged that the > untested code might work or slightly work since there seems to be few > differences between 802 and UFX in a view of vendor-dependent protocol > relevant to packet streaming. > > (I guess that the only difference is the return value of LATTER_SYNC_STATUS > register; bit-swap case or not.) > > Even if it doesn't work well, it's convenient to me to leave a chance to > get any feedback from the users. OK, now applied all six patches. thanks, Takashi