From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408A2C34021 for ; Mon, 17 Feb 2020 13:56:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2C732070B for ; Mon, 17 Feb 2020 13:56:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="hov43Jz0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2C732070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 035E8839; Mon, 17 Feb 2020 14:55:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 035E8839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1581947771; bh=oJu9OxDTj9k6ZzJdzPGrglUuFT15NP0AliTz3qVm1SA=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hov43Jz0t7652NLHbCZusKDZ7Q9eTzeVgYoX2oXvLrFeJOfrjoWZarOtYIzphYXbS gfebRlxUQ6k+qDTlbr1azqki5EtYsplEwvYlasv1L6Ywd03Bw+vo4K83fWeNuG1W9G ZS2Ne0TBsLycJF4+VMaHX9SDYYIYt0raM94BnOYw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4C8DFF8015E; Mon, 17 Feb 2020 14:55:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3FC01F80172; Mon, 17 Feb 2020 14:55:17 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 176FEF800C4 for ; Mon, 17 Feb 2020 14:55:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 176FEF800C4 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 218D8AE2C; Mon, 17 Feb 2020 13:55:14 +0000 (UTC) Date: Mon, 17 Feb 2020 14:55:13 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: References: <20200216203516.10869-1-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, Mark Brown , Pierre-Louis Bossart , Ranjani Sridharan Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 17 Feb 2020 14:17:54 +0100, Kai Vehmanen wrote: > > Hey, > > On Sun, 16 Feb 2020, Takashi Iwai wrote: > > > @@ -200,6 +202,9 @@ int hda_codec_i915_exit(struct snd_sof_dev *sdev) > > struct hdac_bus *bus = sof_to_bus(sdev); > > int ret; > > > > + if (!bus->audio_component) /* not bound with i915 */ > > + return 0; > > + > > hda_codec_i915_display_power(sdev, false); > > > > ret = snd_hdac_i915_exit(bus); > > hmm, actually found the issue in my patch. It turned out to be a bit > suprising issue with acomp&devres. > > snd_hdac_i915_exit() calls > -> snd_hdac_acomp_exit(), which again calls > -> component.c:component_master_del(dev, &hdac_component_master_ops); > -> component.c:take_down_master() > -> devres.c:devres_release_group(master->dev, NULL); > > ... now that is somewhat suprising. Basicly that goes on to release all > devres resources for the hdac_bus device (not just those related to > acomp!). Does it really? I thought it applies only to the group, and id=NULL indicating that it's a local group that was created with id=NULL (by address match). Takashi > > I can fix my immediate problem by not calling snd_hdac_i915_exit() if > hdac_bus contineus to be used, but I'm a bit worried we could hit this in > other flows. > > Anyways, FYI at least for the list archives. > > Br, Kai > _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel