From: Takashi Iwai <tiwai@suse.de>
To: Kailang <kailang@realtek.com>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
Subject: Re: ALC700 headphone no sound issue
Date: Wed, 05 Dec 2018 10:58:10 +0100 [thread overview]
Message-ID: <s5hk1kouwgd.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5hlg54uwmq.wl-tiwai@suse.de>
On Wed, 05 Dec 2018 10:54:21 +0100,
Takashi Iwai wrote:
>
> On Wed, 05 Dec 2018 10:49:56 +0100,
> Takashi Iwai wrote:
> >
> > On Wed, 05 Dec 2018 09:18:52 +0100,
> > Kailang wrote:
> > >
> > > Hi Takashi,
> > >
> > > In Intel ENG board with ALC700. It had headphone no sound issue.
> > > If it plugged headphone or headset into the jack, then do the reboot, it will have a chance to cause headphone no sound.
> > > It just need to run the headphone mode procedure after boot time.
> > > The issue will be fixed.
> > > It also suitable for ALC234 ALC274 and ALC294.
> >
> > Does this correspond to the HDA_FIXUP_ACT_INIT part of the patch?
>
> Bah, scratch that, I looked into a wrong patch (what you've sent
> before). Now checking the right one.
OK, now reviewed.
The change looks mostly OK, but a couple of things:
- hp_pin is not guaranteed to be present;
it should check the case of hp_pin=0, too
- Please give some comment to the function, otherwise it's really
mystery without answer.
You can just put the text in the patch description there.
Could you fix these and resubmit? Thanks!
Takashi
next prev parent reply other threads:[~2018-12-05 9:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 8:18 ALC700 headphone no sound issue Kailang
2018-12-05 9:49 ` Takashi Iwai
2018-12-05 9:54 ` Takashi Iwai
2018-12-05 9:58 ` Takashi Iwai [this message]
2018-12-07 7:19 ` Kailang
2018-12-07 9:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk1kouwgd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.