Re: [PATCH] ALSA: hda: Remove finite loop from snd_hdac_sync_power_state()

[Takashi Iwai <tiwai@suse.de>]

On Tue, 13 Feb 2018 10:09:48 +0100,
abhijeet.kumar@intel.com wrote:
> 
> From: Abhijeet Kumar <abhijeet.kumar@intel.com>
> 
> Finite loop was causing few igt@pm_rpm tests failure for HSW and BDW.
> Thus changing it back to infinite one.

This missing the explanation why the finite loop fails.
I can guess, but some more details please.


Takashi

> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=105069
> 
> Signed-off-by: Abhijeet Kumar <abhijeet.kumar@intel.com>
> ---
>  sound/hda/hdac_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c
> index 7ba100bb1c3f..5a1dd570cea7 100644
> --- a/sound/hda/hdac_device.c
> +++ b/sound/hda/hdac_device.c
> @@ -1079,9 +1079,9 @@ unsigned int snd_hdac_sync_power_state(struct hdac_device *codec,
>  			hda_nid_t nid, unsigned int power_state)
>  {
>  	unsigned long end_time = jiffies + msecs_to_jiffies(500);
> -	unsigned int state, actual_state, count;
> +	unsigned int state, actual_state;
>  
> -	for (count = 0; count < 500; count++) {
> +	for (; ;) {
>  		state = snd_hdac_codec_read(codec, nid, 0,
>  				AC_VERB_GET_POWER_STATE, 0);
>  		if (state & AC_PWRST_ERROR) {
> -- 
> 1.9.1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx