From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B64AEC433ED for ; Sun, 25 Apr 2021 09:17:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B85F61029 for ; Sun, 25 Apr 2021 09:17:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B85F61029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 80E94850; Sun, 25 Apr 2021 11:16:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 80E94850 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619342231; bh=FGMLLkpk+QCg5Y8V/Ae8eav7YhTOw/BEMe0CHnMIxD8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sk0gmYzt3euT6fQUQhbvrat7OCpVvRcPrSLmAlegxnrNb7qTSsf4uASGEvTZHneqr sHDohIn9tuFgE+iQMBG3MHOdg7tHGnH08lNDtfAy4blPP3zkNABBoD1sK61BLVrCoj eWU4M876Ar8r82vCyHJtuX5kRZcwBfaVSnC0Ui7Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EC2BEF801D8; Sun, 25 Apr 2021 11:16:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6637AF801EC; Sun, 25 Apr 2021 11:16:19 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3EDE4F80117 for ; Sun, 25 Apr 2021 11:16:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3EDE4F80117 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C9BEEAF38; Sun, 25 Apr 2021 09:16:08 +0000 (UTC) Date: Sun, 25 Apr 2021 11:16:08 +0200 Message-ID: From: Takashi Iwai To: Lucas Subject: Re: [PATCH 2/2] ALSA: usb-audio: Generic application of implicit fb to Roland/BOSS devices In-Reply-To: References: <20210422120413.457-1-tiwai@suse.de> <20210422120413.457-2-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, "Keith A . Milner" , Mike Oliphant X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 23 Apr 2021 20:04:38 +0200, Lucas wrote: > > On Fri, Apr 23, 2021 at 2:47 AM Takashi Iwai wrote: > > Is this really with snd-usb-audio driver?  Please check the entry in > /proc/asound/modules (or traverse via sysfs). > > No, I see it's not.  It's using the correct snd_ua101 module Then it's expected, and it's been so. I haven't touched snd-ua101 driver code until now. > This rather sounds like a generic problem of the implicit feedback. > Please give the kernel log with snd_usb_audio.dyndbg=+p boot option > with some notion which timestamp corresponding to which action > (e.g. starting playback, stopping recording, etc). > > Okay, that's good news!  Thanks, and here's that: Thanks. Could you try the patch below? Takashi --- a/sound/usb/endpoint.c +++ b/sound/usb/endpoint.c @@ -1443,11 +1443,11 @@ void snd_usb_endpoint_stop(struct snd_usb_endpoint *ep) if (snd_BUG_ON(!atomic_read(&ep->running))) return; - if (ep->sync_source) - WRITE_ONCE(ep->sync_source->sync_sink, NULL); - - if (!atomic_dec_return(&ep->running)) + if (!atomic_dec_return(&ep->running)) { + if (ep->sync_source) + WRITE_ONCE(ep->sync_source->sync_sink, NULL); stop_urbs(ep, false); + } } /**