All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Laurence Tratt <laurie@tratt.net>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Add implicit feedback quirk for SSL2+.
Date: Fri, 12 Jun 2020 10:35:34 +0200	[thread overview]
Message-ID: <s5hlfksd6ll.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200611132917.g3w2e5opwquacvzq@overdrive.tratt.net>

On Thu, 11 Jun 2020 15:29:17 +0200,
Laurence Tratt wrote:
> 
> Signed-off-by: Laurence Tratt <laurie@tratt.net>

No changelog comment is always a bad sign.
Please give a bit more description, e.g. what you've tested and
worked, etc.


thanks,

Takashi

> ---
>  sound/usb/pcm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git sound/usb/pcm.c sound/usb/pcm.c
> index 8a05dcb13..84c0ae431 100644
> --- sound/usb/pcm.c
> +++ sound/usb/pcm.c
> @@ -367,6 +367,7 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>  		ifnum = 0;
>  		goto add_sync_ep_from_ifnum;
>  	case USB_ID(0x07fd, 0x0008): /* MOTU M Series */
> +	case USB_ID(0x31e9, 0x0002): /* Solid State Logic SSL2+ */
>  		ep = 0x81;
>  		ifnum = 2;
>  		goto add_sync_ep_from_ifnum;
> -- 
> 2.27.0
> 

  reply	other threads:[~2020-06-12  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 13:29 [PATCH] Add implicit feedback quirk for SSL2+ Laurence Tratt
2020-06-12  8:35 ` Takashi Iwai [this message]
2020-06-12 11:18 Laurence Tratt
2020-06-12 12:47 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlfksd6ll.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=laurie@tratt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.