From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED8E5C43603 for ; Wed, 18 Dec 2019 19:07:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C19D218AC for ; Wed, 18 Dec 2019 19:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ukbzGd+U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C19D218AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6E4D785D; Wed, 18 Dec 2019 20:06:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6E4D785D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576696024; bh=FnfkVEByfVlgq0+EU2J37CoC1PVXIYXGb5wKOfNYq5Y=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ukbzGd+U76NK53Ttdvpuffbb3970jtP+29F9rxVq8utyLjVHXoBhQ+pqFjBt4X6Je 2w6/VmKftQCLA5+IBuO6WLFL8L9sXQcfwbkN4Kued12qFZwoJqFszPvPyt3s/qvikk imCfGewZCJcp+qvk52qmuitACIzAK+NASRrqUh00= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0322CF8015A; Wed, 18 Dec 2019 20:06:14 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8502EF8022C; Wed, 18 Dec 2019 20:06:12 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0551EF80059 for ; Wed, 18 Dec 2019 20:06:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0551EF80059 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B004FAC50; Wed, 18 Dec 2019 19:06:08 +0000 (UTC) Date: Wed, 18 Dec 2019 20:06:08 +0100 Message-ID: From: Takashi Iwai To: Hui Wang In-Reply-To: <20191218132650.6303-1-hui.wang@canonical.com> References: <20191218132650.6303-1-hui.wang@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: set the interface format after resume on Dell WD19 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 18 Dec 2019 14:26:50 +0100, Hui Wang wrote: > > Recently we found the headset-mic on the Dell Dock WD19 doesn't work > anymore after s3 (s2i or deep), this problem could be workarounded by > closeing (pcm_close) the app and then reopening (pcm_open) the app, so > this bug is not easy to be detected by users. > > When problem happens, retire_capture_urb() could still be called > periodically, but the size of captured data is always 0, it could be > a firmware bug on the dock. Anyway I found after resuming, the > snd_usb_pcm_prepare() will be called, and if we forcibly run > set_format() to set the interface and its endpoint, the capture > size will be normal again. This problem and workaound also apply to > playback. > > To fix it in the kernel, add a quirk to let set_format() run > forcibly once after resume. > > Signed-off-by: Hui Wang Thanks, the workaround looks reasonable. I applied it now with Cc to stable. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel