Re: ALC700 in the Intel chipset

* Re: ALC700 in the Intel chipset
       [not found]         ` <s5h4lsmvntp.wl-tiwai@suse.de>
@ 2017-09-01  8:55           ` Pshou
  2017-09-01  9:02             ` Takashi Iwai
  2017-09-01  9:03           ` ALC700 in the Intel chipset Pshou
  1 sibling, 1 reply; 7+ messages in thread
From: Pshou @ 2017-09-01  8:55 UTC (permalink / raw)
  To: Takashi Iwai, alsa-devel; +Cc: Kailang, Singh, Guneshwor O, CHLin

[-- Attachment #1: Type: text/plain, Size: 2504 bytes --]

Hi  alsa-devel ML:

Could  you merge this 000-alc700-intel.patch file to your ALSA driver?

I changed "Intel debug" to "Intel Reference board". 

Best regards
Pshou

-----Original Message-----
From: Takashi Iwai [mailto:tiwai@suse.de] 
Sent: Friday, September 01, 2017 4:13 PM
To: Pshou
Cc: CHLin; Kailang; Singh, Guneshwor O
Subject: Re: ALC700 in the Intel chipset

On Fri, 01 Sep 2017 10:06:13 +0200,
Pshou wrote:
> 
> Hi Takashi:
> 
> This is 0000-alc700-intel.patch file.

Thanks, it looks good now.
One thing to be changed is the name "Intel debug".
Maybe "Intel Reference board" or such would fit better.

In anyway, could you submit the patch to alsa-devel ML?
Once after it's submitted, I'll merge it.


thanks,

Takashi


> 
> Best regards
> pshou
> 
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Tuesday, August 22, 2017 5:04 PM
> To: CHLin
> Cc: Pshou; Kailang; Singh, Guneshwor O
> Subject: Re: ALC700 in the Intel chipset
> 
> On Tue, 22 Aug 2017 10:05:18 +0200,
> CHLin wrote:
> > 
> > Hi Takashi
> > 
> > ALC 700 needs this patch for jack detection function.
> > Because ALC700's jack detect function defaults is disable.
> > So alc700 needs pathc to enable jack detection function.
> 
> OK, then could you update the patch description for giving more such information, prepare the proper patch in a form described in Documentation/SubmittingPatches with signed-off-by tags?
> This is mandatory for merging to upstream.
> 
> 
> thanks,
> 
> Takashi
> 
> > Thanks.
> > 
> > =======================
> > Realtek Semiconductor Corp.
> > 林家賢 CH_Lin
> > System Design Dept II PCBG
> > Tel: 886-3-578-0211 ext:13162
> > =======================
> > 
> > 
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de]
> > Sent: Monday, August 21, 2017 6:23 PM
> > To: Pshou
> > Cc: Kailang; Singh, Guneshwor O; CHLin
> > Subject: Re: ALC700 in the Intel chipset
> > 
> > On Mon, 21 Aug 2017 10:05:25 +0200,
> > Pshou wrote:
> > > 
> > > Hi Tiwai:
> > > 
> > > Nice to meet you.
> > > 
> > > This is the case of intel.
> > > Fixing Jack detection on ALC700
> > 
> > Could you give more information about this patch?
> > For which platform and for what problem?  At best, please add more information in the patch changelog itself.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0000-alc700-intel.patch --]
[-- Type: application/octet-stream, Size: 2173 bytes --]

From ab9b9409f5d3ca7f0bb14b56c9a7f9d2ccaed814 Mon Sep 17 00:00:00 2001
From: PeiSen Hou <pshou@realtek.com>
Date: Fri, 1 Sep 2017 15:11:56 +0800
Subject: [PATCH] ALSA: hda/realtek - Enable jack detection function for Intel
 ALC700

Intel ALC 700 needs this patch for jack detection function.
Because ALC700's jack detect function defaults is disable.
So alc700 needs pathc to enable jack detection function.

Signed-off-by: PeiSen Hou <pshou@realtek.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 217bb58..29cb79a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5263,6 +5263,7 @@ enum {
 	ALC233_FIXUP_EAPD_COEF_AND_MIC_NO_PRESENCE,
 	ALC233_FIXUP_LENOVO_MULTI_CODECS,
 	ALC294_FIXUP_LENOVO_MIC_LOCATION,
+	ALC700_FIXUP_INTEL_DEBUG,
 };
 
 static const struct hda_fixup alc269_fixups[] = {
@@ -6058,6 +6059,21 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ }
 		},
 	},
+	[ALC700_FIXUP_INTEL_DEBUG] = {
+		.type = HDA_FIXUP_VERBS,
+		.v.verbs = (const struct hda_verb[]) {
+			/* Enables internal speaker */
+			{0x20, AC_VERB_SET_COEF_INDEX, 0x45},
+			{0x20, AC_VERB_SET_PROC_COEF, 0x5289},
+			{0x20, AC_VERB_SET_COEF_INDEX, 0x4A},
+			{0x20, AC_VERB_SET_PROC_COEF, 0x001b},
+			{0x58, AC_VERB_SET_COEF_INDEX, 0x00},
+			{0x58, AC_VERB_SET_PROC_COEF, 0x3888},
+			{0x20, AC_VERB_SET_COEF_INDEX, 0x6f},
+			{0x20, AC_VERB_SET_PROC_COEF, 0x2c0b},
+			{}
+		}
+	},
 };
 
 static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -6209,6 +6225,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x10cf, 0x15dc, "Lifebook T731", ALC269_FIXUP_LIFEBOOK_HP_PIN),
 	SND_PCI_QUIRK(0x10cf, 0x1757, "Lifebook E752", ALC269_FIXUP_LIFEBOOK_HP_PIN),
 	SND_PCI_QUIRK(0x10cf, 0x1845, "Lifebook U904", ALC269_FIXUP_LIFEBOOK_EXTMIC),
+	SND_PCI_QUIRK(0x10ec, 0x10f2, "Intel debug", ALC700_FIXUP_INTEL_DEBUG),
 	SND_PCI_QUIRK(0x144d, 0xc109, "Samsung Ativ book 9 (NP900X3G)", ALC269_FIXUP_INV_DMIC),
 	SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
 	SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] 7+ messages in thread