All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: boozer asm <asmboozer@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: memory leak in mix/pcm_upmix.c mix/pcm_downmix.c!!!
Date: Wed, 30 Aug 2017 10:17:50 +0200	[thread overview]
Message-ID: <s5hlgm179ld.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAOccgsV5qoHj8bR5wsPNXieAGhCQM4dtBEWe3jE_NXxYQwcUKg@mail.gmail.com>

On Wed, 30 Aug 2017 09:59:59 +0200,
boozer asm wrote:
> 
> Hi  Takashi,
> 
> i think mix is same as ext->data instead ext. ext is of extplug_priv_t *;
> so it is definitely not mix which is of snd_pcm_upmix_t
> 
>  33 struct snd_pcm_upmix {
>  34     snd_pcm_extplug_t ext;
> 
> typedef struct snd_pcm_extplug_priv {
>     snd_pcm_plugin_t plug;
>     snd_pcm_extplug_t *data;
> between upmix and extplug_priv, there is a gap plug, which forbid ext to be
> converted to mix directly.
> so free(ext) in snd_pcm_extplug_close does NOT promise it will free mix too.

OK, then care to submit patches?


thanks,

Takashi

  reply	other threads:[~2017-08-30  8:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  5:51 memory leak in mix/pcm_upmix.c mix/pcm_downmix.c!!! boozer asm
2017-08-30  5:55 ` boozer asm
2017-08-30  7:02 ` Takashi Iwai
2017-08-30  7:59   ` boozer asm
2017-08-30  8:17     ` Takashi Iwai [this message]
2017-08-30  8:28       ` boozer asm
2017-08-30  8:32         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlgm179ld.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=asmboozer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.