From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbaKUTIK (ORCPT ); Fri, 21 Nov 2014 14:08:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60890 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbaKUTIH (ORCPT ); Fri, 21 Nov 2014 14:08:07 -0500 Date: Fri, 21 Nov 2014 20:08:05 +0100 Message-ID: From: Takashi Iwai To: SF Markus Elfring Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 1/1] ALSA: es1688_lib: Deletion of an unnecessary check before the function call "release_and_free_resource" In-Reply-To: <546F8063.3090002@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F8063.3090002@users.sourceforge.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 21 Nov 2014 19:11:47 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Fri, 21 Nov 2014 19:05:50 +0100 > > The release_and_free_resource() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied, thanks. Takashi > --- > sound/isa/es1688/es1688_lib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c > index b3b4f15..fb259491 100644 > --- a/sound/isa/es1688/es1688_lib.c > +++ b/sound/isa/es1688/es1688_lib.c > @@ -614,8 +614,7 @@ static int snd_es1688_free(struct snd_es1688 *chip) > { > if (chip->hardware != ES1688_HW_UNDEF) > snd_es1688_init(chip, 0); > - if (chip->res_port) > - release_and_free_resource(chip->res_port); > + release_and_free_resource(chip->res_port); > if (chip->irq >= 0) > free_irq(chip->irq, (void *) chip); > if (chip->dma8 >= 0) { > -- > 2.1.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Date: Fri, 21 Nov 2014 19:08:05 +0000 Subject: Re: [PATCH 1/1] ALSA: es1688_lib: Deletion of an unnecessary check before the function call "release Message-Id: List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F8063.3090002@users.sourceforge.net> In-Reply-To: <546F8063.3090002@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall At Fri, 21 Nov 2014 19:11:47 +0100, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Fri, 21 Nov 2014 19:05:50 +0100 > > The release_and_free_resource() function tests whether its argument is NULL > and then returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied, thanks. Takashi > --- > sound/isa/es1688/es1688_lib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/isa/es1688/es1688_lib.c b/sound/isa/es1688/es1688_lib.c > index b3b4f15..fb259491 100644 > --- a/sound/isa/es1688/es1688_lib.c > +++ b/sound/isa/es1688/es1688_lib.c > @@ -614,8 +614,7 @@ static int snd_es1688_free(struct snd_es1688 *chip) > { > if (chip->hardware != ES1688_HW_UNDEF) > snd_es1688_init(chip, 0); > - if (chip->res_port) > - release_and_free_resource(chip->res_port); > + release_and_free_resource(chip->res_port); > if (chip->irq >= 0) > free_irq(chip->irq, (void *) chip); > if (chip->dma8 >= 0) { > -- > 2.1.3 >