All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Fix missing stream for second ADC on Realtek	ALC260 HDA codec
Date: Mon, 09 Aug 2010 08:43:36 +0200	[thread overview]
Message-ID: <s5hlj8gz3on.wl%tiwai@suse.de> (raw)
In-Reply-To: <201008071447.o77El5x2026067@mercury.physics.adelaide.edu.au>

At Sun, 8 Aug 2010 00:17:05 +0930 (CST),
Jonathan Woithe wrote:
> 
> Hi all
> 
> I discovered tonight that ALSA no longer sets up a stream for the second ADC
> provided by the Realtek ALC260 HDA codec.  At some point alc_build_pcms()
> started using stream_analog_alt_capture when constructing the second ADC
> stream, but patch_alc260() was never updated accordingly.  I have no idea
> when this regression occurred.  The trivial patch to patch_alc260() given
> below fixes the problem as far as I can tell.  The patch is against 2.6.35.
> 
> Signed-off-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>

Thanks, applied now with Cc to stable kernel.


Takashi

> 
> --- linux-2.6.35-orig/sound/pci/hda/patch_realtek.c	2010-08-02 07:41:14.000000000 +0930
> +++ linux-2.6.35/sound/pci/hda/patch_realtek.c	2010-08-08 00:06:19.670695899 +0930
> @@ -6863,6 +6863,7 @@
>  
>  	spec->stream_analog_playback = &alc260_pcm_analog_playback;
>  	spec->stream_analog_capture = &alc260_pcm_analog_capture;
> +	spec->stream_analog_alt_capture = &alc260_pcm_analog_capture;
>  
>  	spec->stream_digital_playback = &alc260_pcm_digital_playback;
>  	spec->stream_digital_capture = &alc260_pcm_digital_capture;
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

      reply	other threads:[~2010-08-09  6:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-07 14:47 [PATCH] Fix missing stream for second ADC on Realtek ALC260 HDA codec Jonathan Woithe
2010-08-09  6:43 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlj8gz3on.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jwoithe@physics.adelaide.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.