From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Quality resampling code for libasound Date: Tue, 20 Mar 2007 15:19:05 +0100 Message-ID: References: <45D92131.50601@usherbrooke.ca> <45D99DF7.90204@usherbrooke.ca> <45D9A848.9040803@usherbrooke.ca> <45DA8CD2.1040606@usherbrooke.ca> <45DAE188.6010405@usherbrooke.ca> <45DAEBB8.70808@usherbrooke.ca> <45DB713F.9090804@superbug.co.uk> <45DC0E52.1060805@usherbrooke.ca> <45DD8329.6080809@usherbrooke.ca> <45E4E4A5.6020405@usherbrooke.ca> <45EF5FE1.5080407@usherbrooke.ca> <45FFE014.1080100@usherbrooke.ca> <45FFEAA9.4040606@usherbrooke.ca> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45FFEAA9.4040606@usherbrooke.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Jean-Marc Valin Cc: alsa-devel@lists.sourceforge.net, James Courtier-Dutton List-Id: alsa-devel@alsa-project.org At Wed, 21 Mar 2007 01:07:37 +1100, Jean-Marc Valin wrote: > > > Thanks. > > It would be helpful if you provide a diff rather a complete tarball at > > the next time. > > OK, I'll do that next time. > > >> diff -r 0bcf6f07c12c pph/rate_speexrate.c > >> --- a/pph/rate_speexrate.c Thu Mar 08 12:54:57 2007 +0100 > >> +++ b/pph/rate_speexrate.c Tue Mar 20 14:08:30 2007 +0100 > >> @@ -29,6 +29,7 @@ > >> */ > >> > >> #include > >> +#include > >> #include > > > > This requires additional check in configure. > > Why is this header needed now? > > Oops, that's a mistake. There's no need for that include. Actually, it > was also in the previous version I sent, so it's strange you're only > noticing it now. Heh, that's an advantage of reviewing a patch ;) > >> @@ -42,7 +43,7 @@ struct rate_src { > >> > >> static snd_pcm_uframes_t input_frames(void *obj, snd_pcm_uframes_t frames) > >> { > >> - int num, den; > >> + spx_uint32_t num, den; > > > > I don't see big merits to use its own types here... > > Well, I use that type because that's what is used in the API. And the > reason I use it in the API is because this code is meant to work even on > platforms with 16-bit integers (e.g. TI C5X DSPs) and no C99 compiler. > If that's causing problem, I guess you could still use unsigned int with > no problem... Don't worry, alsa-lib would be very unlikely ported to such an architecture. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV