From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Quality resampling code for libasound Date: Thu, 22 Feb 2007 13:07:58 +0100 Message-ID: References: <45D92131.50601@usherbrooke.ca> <45D99DF7.90204@usherbrooke.ca> <45D9A848.9040803@usherbrooke.ca> <45DA8CD2.1040606@usherbrooke.ca> <45DAE188.6010405@usherbrooke.ca> <45DAEBB8.70808@usherbrooke.ca> <45DB713F.9090804@superbug.co.uk> <45DC0E52.1060805@usherbrooke.ca> <45DD8329.6080809@usherbrooke.ca> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45DD8329.6080809@usherbrooke.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@lists.sourceforge.net Errors-To: alsa-devel-bounces@lists.sourceforge.net To: Jean-Marc Valin Cc: alsa-devel@lists.sourceforge.net, James Courtier-Dutton List-Id: alsa-devel@alsa-project.org At Thu, 22 Feb 2007 22:48:57 +1100, Jean-Marc Valin wrote: > > > Thanks, now committed to HG tree. > > Good, thanks. > > >> So I'm attaching both a patch for rate_samplerate and a new version of > >> my resampler plugin (now BSD-licensed). Both seem to work much better > >> with the numerator and denominator in the right place. I still haven't > >> changed the code to resolve the symbol conflict, but I'll do that soon. > > > > Regarding the license, LGPL would be suitable especailly if thinking > > about merging the code to alsa-lib tree later. Other codes in > > alsa-lib are all LGPL, so putting a BSD piece isn't fun. The license > > can be changed at merge time, though. > > Of course, if you prefer BSD, it's fine. We can keep it as is. > > I don't mind at all relicensing to plugin to LGPL, since it's a part of > ALSA anyway. The resampler itself is BSD and whenever possible, I'd > really like to have any patch/fix to it available under the BSD. In any > case, since any BSD code can be easily integrated into LGPL code, it > shouldn't be a problem. Yes. I'll apply your current version to the HG tree now, then. > >> Can everyone give this a bit of testing? I hope we can soon get rid of > >> linear resampling as the default resampling once and for all. > > > > Looks working good as long as I've tested. > > Could you give a short document for this plugin, too (put in > > alsa-firmware/doc)? > > What kind of document do you want? I can't find anything about the other > sample rate converters, so I'm not sure what it should look like. A brief instruction how to set up would be enough. See alsa-plugins/doc/samplerate.txt, for example. Although it's planned to be merged in future, a documentation is always nice to have :) thanks, Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV