From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D5FBC433F5 for ; Tue, 4 Jan 2022 15:33:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233535AbiADPdP (ORCPT ); Tue, 4 Jan 2022 10:33:15 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:45150 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232664AbiADPdO (ORCPT ); Tue, 4 Jan 2022 10:33:14 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3CF3E210E7; Tue, 4 Jan 2022 15:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1641310393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SCPSpj9hbG7rnnfKiBSNlp2wmz7qAvWj0UuKAmVikw=; b=bvXJqmEqBXb0rd48JIrlIIQ3ik5nNxMXZjEXPT8ciuPcnW2QvY6wpbkcKILh81gCaGMVke sMjuK2cw2e6GWqqVeOX/f/vQoumKxmZ3GLGwSsy/Y0AAMUWuXN7+feYrsIk97z+SMvZqh1 6zeA3o3gMJ5ssAAejPCNq/oR8LIvxqY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1641310393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SCPSpj9hbG7rnnfKiBSNlp2wmz7qAvWj0UuKAmVikw=; b=mUmhi+9FS0pKcxouznWU/Gx3oiIlHDa4krIDFRJu+VRasHzwe3aRx39GMEuWrwLN3/Yv7H NszKk/o0QjTWflCg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 2452AA3B83; Tue, 4 Jan 2022 15:33:13 +0000 (UTC) Date: Tue, 04 Jan 2022 16:33:13 +0100 Message-ID: From: Takashi Iwai To: "Christian A. Ehrhardt" Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Lucas Tanure , Stefan Binding , Vitaly Rodionov , Takashi Iwai , Jaroslav Kysela Subject: Re: hda/cs8409: Fix internal speaker detection In-Reply-To: <20211231131221.itwotyfk5qomn7n6@cae.in-ulm.de> References: <20211231131221.itwotyfk5qomn7n6@cae.in-ulm.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Dec 2021 14:12:21 +0100, Christian A. Ehrhardt wrote: > > > Hi, > > I have a DELL Inspirion 3501 laptop with a cirrus cs8904 HDA codec. > With more recent kernels the internal speakers stopped working. > I bisected the issue and tracked it down to this commit > > | commit c8b4f0865e82c14924c69c07d985af3ee9133316 > | Author: Stefan Binding > | Date: Wed Aug 11 19:56:52 2021 +0100 > | > | ALSA: hda/cs8409: Remove unnecessary delays > > After a bit of experimenting with the timeouts I came > up with the patch below that fixes the issue for me. > > However, I don't have the specs for the chip, i.e. I don't > know what a theoretically correct value would be. > > Suggested patch below, please consider inclusion. > > regards Christian > > >From 9c796d221171c6d12fd84ae4f5c8315030c8c4ca Mon Sep 17 00:00:00 2001 > From: "Christian A. Ehrhardt" > Date: Fri, 31 Dec 2021 10:33:19 +0100 > Subject: [PATCH 1/2] ALSA: hda/cs8409: Increase delay during jack detection > > Commit c8b4f0865e82 reduced delays related to cs42l42 jack > detection. However, the change was too aggressive. As a result > internal speakers on DELL Inspirion 3501 ac8b4f0865e82re not detected. > > Increase the delay in cs42l42_run_jack_detect() a bit. > > Fixes: c8b4f0865e82 ("ALSA: hda/cs8409: Remove unnecessary delays") > Signed-off-by: Christian A. Ehrhardt Thanks, applied now. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDC07C433EF for ; Tue, 4 Jan 2022 15:34:18 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 194DB16FF; Tue, 4 Jan 2022 16:33:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 194DB16FF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1641310456; bh=yAlvaf6ifHZeYHHbjSkIMaP1ZHfk0FufTt1QzZzPB7w=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hFR+3jLg/IlBMkq01zPDXwePZTI4dsNEa+3SjcX+SlROiJ6L1diXcR9Z0IqA5cbAh lmQavzx2UlD1hxiump8jfnNJLqHfIqYmjWh8IKGvXMO/IbdxLqQck+UeBD5T1yo8uV yj/Ki/o9gxBpYqzattoFKGg62pnwxmuJ6k/qyAPM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 927F3F8027C; Tue, 4 Jan 2022 16:33:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E3804F80310; Tue, 4 Jan 2022 16:33:21 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 90FD2F80089 for ; Tue, 4 Jan 2022 16:33:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 90FD2F80089 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bvXJqmEq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="mUmhi+9F" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 3CF3E210E7; Tue, 4 Jan 2022 15:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1641310393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SCPSpj9hbG7rnnfKiBSNlp2wmz7qAvWj0UuKAmVikw=; b=bvXJqmEqBXb0rd48JIrlIIQ3ik5nNxMXZjEXPT8ciuPcnW2QvY6wpbkcKILh81gCaGMVke sMjuK2cw2e6GWqqVeOX/f/vQoumKxmZ3GLGwSsy/Y0AAMUWuXN7+feYrsIk97z+SMvZqh1 6zeA3o3gMJ5ssAAejPCNq/oR8LIvxqY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1641310393; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9SCPSpj9hbG7rnnfKiBSNlp2wmz7qAvWj0UuKAmVikw=; b=mUmhi+9FS0pKcxouznWU/Gx3oiIlHDa4krIDFRJu+VRasHzwe3aRx39GMEuWrwLN3/Yv7H NszKk/o0QjTWflCg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 2452AA3B83; Tue, 4 Jan 2022 15:33:13 +0000 (UTC) Date: Tue, 04 Jan 2022 16:33:13 +0100 Message-ID: From: Takashi Iwai To: "Christian A. Ehrhardt" Subject: Re: hda/cs8409: Fix internal speaker detection In-Reply-To: <20211231131221.itwotyfk5qomn7n6@cae.in-ulm.de> References: <20211231131221.itwotyfk5qomn7n6@cae.in-ulm.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Lucas Tanure , Vitaly Rodionov , Takashi Iwai , linux-kernel@vger.kernel.org, Stefan Binding X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 31 Dec 2021 14:12:21 +0100, Christian A. Ehrhardt wrote: > > > Hi, > > I have a DELL Inspirion 3501 laptop with a cirrus cs8904 HDA codec. > With more recent kernels the internal speakers stopped working. > I bisected the issue and tracked it down to this commit > > | commit c8b4f0865e82c14924c69c07d985af3ee9133316 > | Author: Stefan Binding > | Date: Wed Aug 11 19:56:52 2021 +0100 > | > | ALSA: hda/cs8409: Remove unnecessary delays > > After a bit of experimenting with the timeouts I came > up with the patch below that fixes the issue for me. > > However, I don't have the specs for the chip, i.e. I don't > know what a theoretically correct value would be. > > Suggested patch below, please consider inclusion. > > regards Christian > > >From 9c796d221171c6d12fd84ae4f5c8315030c8c4ca Mon Sep 17 00:00:00 2001 > From: "Christian A. Ehrhardt" > Date: Fri, 31 Dec 2021 10:33:19 +0100 > Subject: [PATCH 1/2] ALSA: hda/cs8409: Increase delay during jack detection > > Commit c8b4f0865e82 reduced delays related to cs42l42 jack > detection. However, the change was too aggressive. As a result > internal speakers on DELL Inspirion 3501 ac8b4f0865e82re not detected. > > Increase the delay in cs42l42_run_jack_detect() a bit. > > Fixes: c8b4f0865e82 ("ALSA: hda/cs8409: Remove unnecessary delays") > Signed-off-by: Christian A. Ehrhardt Thanks, applied now. Takashi