From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEFFBC432BE for ; Tue, 3 Aug 2021 14:05:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B55F960EC0 for ; Tue, 3 Aug 2021 14:05:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236474AbhHCOF4 (ORCPT ); Tue, 3 Aug 2021 10:05:56 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:47400 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236045AbhHCOFz (ORCPT ); Tue, 3 Aug 2021 10:05:55 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 843672003F; Tue, 3 Aug 2021 14:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627999543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KB9J6Yc/9eRj2qPkgvDqfREMnT7BDt/roGrjEKRDPyo=; b=Ns3csEQPJq7kDx9y1hp638rKj5iQdiKUKbipvtGsXi36DTY9Tng7AXFNNNPKqIPOmcY7Rg EmVjOd4BIHw7jgUXhh8bfwHE0V4p/icnEcpwqTgdsDLEfRoh9zPUaU+MtLFLl43EnFd3Z0 owU2CtFhF+if90FpT6QCV5l/aWBvRLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627999543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KB9J6Yc/9eRj2qPkgvDqfREMnT7BDt/roGrjEKRDPyo=; b=+pFfeUa+Ix2NTtlc4wifs7o18heExOFldNIRWWN0dQplxACrjpjzhHdQKI2ghVAFTsHJzk 6cdoYIMxiQbcj4BA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 72B92A3BD1; Tue, 3 Aug 2021 14:05:43 +0000 (UTC) Date: Tue, 03 Aug 2021 16:05:43 +0200 Message-ID: From: Takashi Iwai To: Colin King Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller In-Reply-To: <20210803122839.7143-1-colin.king@canonical.com> References: <20210803122839.7143-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Aug 2021 14:28:39 +0200, Colin King wrote: > > From: Colin Ian King > > Don't populate array names_to_check on the stack but instead it > static. Makes the object code smaller by 56 bytes. Also clean > up checkpatch warning by adding extra const for names_to_check > and pointer s. > > Before: > text data bss dec hex filename > 103512 34380 0 137892 21aa4 ./sound/usb/mixer.o > > After: > text data bss dec hex filename > 103264 34572 0 137836 21a6c ./sound/usb/mixer.o > > (gcc version 10.2.0) > > Signed-off-by: Colin Ian King > --- > > V2: Clean up checkpatch warning on const-ness for names_to_check. > Add extra const to clean up build warning on pointer s. Thanks, applied. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660A3C4338F for ; Tue, 3 Aug 2021 14:06:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BE0D60F46 for ; Tue, 3 Aug 2021 14:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BE0D60F46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F11F71898; Tue, 3 Aug 2021 16:05:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F11F71898 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627999603; bh=+cmEzDjZ9fcxBLMc2NPTBr6C6YaxJcjTptJfNQBdIG0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Dv3JQMhBXNJiBSvnSWWGEhweWXsOs3DdBV4gOpOLZfuB4LVtRKwnNiwG+77MoYG/O ftyzfky1rU80s+UITfwX/9SsZXTbNmu7VKKg0C66Yg1Q65EBj7uD6rYa+lVn6fcHrB YCge2Q8B//dO3ChkCv4P9b7DKghEK07h/DRM6atk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7C69EF8014D; Tue, 3 Aug 2021 16:05:52 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E64BFF802E8; Tue, 3 Aug 2021 16:05:50 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03313F80095 for ; Tue, 3 Aug 2021 16:05:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03313F80095 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Ns3csEQP"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+pFfeUa+" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 843672003F; Tue, 3 Aug 2021 14:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627999543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KB9J6Yc/9eRj2qPkgvDqfREMnT7BDt/roGrjEKRDPyo=; b=Ns3csEQPJq7kDx9y1hp638rKj5iQdiKUKbipvtGsXi36DTY9Tng7AXFNNNPKqIPOmcY7Rg EmVjOd4BIHw7jgUXhh8bfwHE0V4p/icnEcpwqTgdsDLEfRoh9zPUaU+MtLFLl43EnFd3Z0 owU2CtFhF+if90FpT6QCV5l/aWBvRLo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627999543; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KB9J6Yc/9eRj2qPkgvDqfREMnT7BDt/roGrjEKRDPyo=; b=+pFfeUa+Ix2NTtlc4wifs7o18heExOFldNIRWWN0dQplxACrjpjzhHdQKI2ghVAFTsHJzk 6cdoYIMxiQbcj4BA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 72B92A3BD1; Tue, 3 Aug 2021 14:05:43 +0000 (UTC) Date: Tue, 03 Aug 2021 16:05:43 +0200 Message-ID: From: Takashi Iwai To: Colin King Subject: Re: [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller In-Reply-To: <20210803122839.7143-1-colin.king@canonical.com> References: <20210803122839.7143-1-colin.king@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 03 Aug 2021 14:28:39 +0200, Colin King wrote: > > From: Colin Ian King > > Don't populate array names_to_check on the stack but instead it > static. Makes the object code smaller by 56 bytes. Also clean > up checkpatch warning by adding extra const for names_to_check > and pointer s. > > Before: > text data bss dec hex filename > 103512 34380 0 137892 21aa4 ./sound/usb/mixer.o > > After: > text data bss dec hex filename > 103264 34572 0 137836 21a6c ./sound/usb/mixer.o > > (gcc version 10.2.0) > > Signed-off-by: Colin Ian King > --- > > V2: Clean up checkpatch warning on const-ness for names_to_check. > Add extra const to clean up build warning on pointer s. Thanks, applied. Takashi