From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AAA6C3524D for ; Mon, 3 Feb 2020 09:54:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1744A2070A for ; Mon, 3 Feb 2020 09:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727202AbgBCJyT (ORCPT ); Mon, 3 Feb 2020 04:54:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:38316 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbgBCJyS (ORCPT ); Mon, 3 Feb 2020 04:54:18 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 166CCAC37; Mon, 3 Feb 2020 09:54:17 +0000 (UTC) Date: Mon, 03 Feb 2020 10:54:16 +0100 Message-ID: From: Takashi Iwai To: Johan Hovold Cc: edes , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: kernel 5.4.11: problems with usb sound cards In-Reply-To: <20200203082908.GR10381@localhost> References: <20200201105829.5682c887@acme7.acmenet> <20200201141009.GK10381@localhost> <20200201132616.09857152@acme7.acmenet> <20200202101933.GL10381@localhost> <20200202134159.GM10381@localhost> <20200202202816.5a1d8af1@acme7.acmenet> <20200203082908.GR10381@localhost> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 03 Feb 2020 09:29:08 +0100, Johan Hovold wrote: > > On Mon, Feb 03, 2020 at 08:57:41AM +0100, Takashi Iwai wrote: > > On Mon, 03 Feb 2020 00:28:16 +0100, > > edes wrote: > > > > > > > > > el 2020-02-02 a las 14:41 Johan Hovold escribió: > > > > > > > I realised I forgot the test to match on the device descriptor when > > > > applying the blacklist. It doesn't matter currently since I only enable > > > > the quirk for your device, but if you haven't tested the patch already, > > > > would you mind testing the below patch instead? > > > > > > Hi, Johan, thank you for looking into this. I tested your patch, and it > > > works! (5.4.11 and 5.5.0). > > > > > > I haven't performed extensive tests, but the card is again recognized as > > > both playback and capture device. Thank you! > > > > > > Is this and acceptable solution and will this patch be integrated into the > > > kernel? > > > > I don't mind where to blacklist; we may add a similar quirk in > > USB-audio driver side, too. > > I'm afraid it needs to be done in core since this info is needed while > parsing the descriptors. OK, then let's go with your patch if there is no objection. thanks, Takashi