From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA6ACA9EC0 for ; Mon, 28 Oct 2019 18:05:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E28FF21744 for ; Mon, 28 Oct 2019 18:05:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="qcS+DxOS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E28FF21744 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CBD6D20AA; Mon, 28 Oct 2019 19:04:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CBD6D20AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572285938; bh=VrbUdUBNImXJBppSbfMvrURsd/GvzT+BDWpHZ7BqieY=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qcS+DxOSwg11hya8z8AzfvM4HpB/p4S8RjJcJnfG/vERWQIduVhWj9ub3WTjP71CA YX42NHat0a4om3r+fir8WHJ/vHT1RXqVlk3Ie2DVxadwkcv3FMW1VJr1SMj3mSI1l/ Jnl1g6OPsRfL53jUK35hU0GQcF/NtjC15bM2ehn4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 36140F802BD; Mon, 28 Oct 2019 19:04:48 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30BF8F80361; Mon, 28 Oct 2019 19:04:42 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 84917F8011D for ; Mon, 28 Oct 2019 19:04:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 84917F8011D X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E3103AB91; Mon, 28 Oct 2019 18:04:34 +0000 (UTC) Date: Mon, 28 Oct 2019 19:04:34 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen In-Reply-To: References: <20191023090331.10531-1-kai.vehmanen@linux.intel.com> <20191023090331.10531-7-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: libin.yang@intel.com, alsa-devel@alsa-project.org, broonie@kernel.org, pierre-louis.bossart@linux.intel.com Subject: Re: [alsa-devel] [PATCH v7 6/9] ASoC: Intel: bxt-da7219-max98357a: common hdmi codec support X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 28 Oct 2019 18:33:44 +0100, Kai Vehmanen wrote: > > Hi, > > thanks for the review! > > On Mon, 28 Oct 2019, Takashi Iwai wrote: > > > On Wed, 23 Oct 2019 11:03:28 +0200, > > Kai Vehmanen wrote: > > > -snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o > > > +snd-soc-sst-bxt-da7219_max98357a-objs := bxt_da7219_max98357a.o hda_dsp_common.o > > > > Hrm, this can be a problem. I see there are multiple drivers that are > > built with this object. When they are built as modules and more than > > one module get loaded on a system, it'll lead to a conflict because > > both modules try to put the same stuff. > [...] > > But I'm not entirely sure whether this is true on the recent kernel > > build. At least it *was* a problem in the past. > > > > In anyway, please try to load the two modules on your system and check > > whether the module loading works. > > hmm, did a quick test and no problems seen, all modules load fine. > > Another option is to go back to solution in v6 of the series and > have the helper functions inlines. But it seems v7 works as well, so maybe > we'll stick with this. Hrm, then it might be built-in + module mixed case. If that works, it implies that my concern can be ignored. Let's see. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel