From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 11/39] ALSA: seq: optimize system_info function to new design Date: Mon, 08 Aug 2016 09:50:08 +0200 Message-ID: References: <1470563355-18368-1-git-send-email-o-takashi@sakamocchi.jp> <1470563355-18368-12-git-send-email-o-takashi@sakamocchi.jp> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id BB22F2664CF for ; Mon, 8 Aug 2016 09:50:09 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Takashi Sakamoto Cc: alsa-devel@alsa-project.org, clemens@ladisch.de List-Id: alsa-devel@alsa-project.org On Mon, 08 Aug 2016 09:04:55 +0200, Takashi Iwai wrote: > > On Sun, 07 Aug 2016 11:48:47 +0200, > Takashi Sakamoto wrote: > > > > In former commit, actual operations of each ioctl command get argument > > in kernel space. Copying from/to user space is performed outside of > > the function. > > > > This commit optimizes to the new design. > > > > Signed-off-by: Takashi Sakamoto > > While it's OK to split to small patches if you prefer, you don't have > to do so. Basically all the rest are doing the same thing (strip > copy_*_user() and replace to the pointer accesses), and it's rather > boring to read repeated mails. BTW, I'm afraid that the patch series breaks bisection. We need to consider rearranging the changes if we want to keep bisectionability. Takashi