From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C974AC433ED for ; Tue, 11 May 2021 09:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8888C611F1 for ; Tue, 11 May 2021 09:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbhEKJL0 (ORCPT ); Tue, 11 May 2021 05:11:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:36254 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231269AbhEKJLP (ORCPT ); Tue, 11 May 2021 05:11:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C1067B16B; Tue, 11 May 2021 09:10:08 +0000 (UTC) Date: Tue, 11 May 2021 11:10:08 +0200 Message-ID: From: Takashi Iwai To: Elia Devito Cc: Jaroslav Kysela , Takashi Iwai , Kailang Yang , Jian-Hong Pan , Hui Wang , Chris Chiu , Huacai Chen , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx In-Reply-To: <20210510171332.8313-1-eliadevito@gmail.com> References: <20210510171332.8313-1-eliadevito@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 May 2021 19:13:33 +0200, Elia Devito wrote: > > Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably > on similar models. > > 0x14 pin config override is required to enable all speakers and > alc285-speaker2-to-dac1 fixup to enable volume adjustment. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331 > Signed-off-by: Elia Devito Could you try to put the quirk entry in the PCI SSID order? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b4b71609dff1..be2a5cd2875d 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6542,6 +6542,7 @@ enum { > ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST, > ALC295_FIXUP_ASUS_DACS, > ALC295_FIXUP_HP_OMEN, > + ALC285_FIXUP_HP_SPECTRE_X360, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED, > }, > + [ALC285_FIXUP_HP_SPECTRE_X360] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x14, 0x90170110 }, /* enable top speaker */ > + {} > + }, > + .chained = true, > + .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1, > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -8278,6 +8288,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > @@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { > {.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"}, > {.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"}, > {.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"}, > + {.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"}, > {} > }; > #define ALC225_STANDARD_PINS \ > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 388F2C433ED for ; Tue, 11 May 2021 09:13:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DEF061923 for ; Tue, 11 May 2021 09:13:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DEF061923 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A76B21792; Tue, 11 May 2021 11:12:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A76B21792 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620724392; bh=lQevgcijG6o2ed86sd/3iJs/5mfVIYIMIn3p4QmE8UM=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=B59IHLj8eWluGaN5RkaM7GaN0SeqSLTgX20EbG4Y/mRQGobtdJZ8kcEyTCqP/vVx7 eASR7UZEnnaBa6tyk/0TtlWTv3npBB7/xQ6+Fj+7lO8SyWZQiI4+5sR94RWktrm+8i rWL2SjfL9h5hJf7hOUGwHpIDmWw9Mh+2hcUiKEu0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9E710F80163; Tue, 11 May 2021 11:10:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 98605F8016B; Tue, 11 May 2021 11:10:18 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EE706F80129 for ; Tue, 11 May 2021 11:10:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EE706F80129 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C1067B16B; Tue, 11 May 2021 09:10:08 +0000 (UTC) Date: Tue, 11 May 2021 11:10:08 +0200 Message-ID: From: Takashi Iwai To: Elia Devito Subject: Re: [PATCH] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx In-Reply-To: <20210510171332.8313-1-eliadevito@gmail.com> References: <20210510171332.8313-1-eliadevito@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Chris Chiu , alsa-devel@alsa-project.org, Kailang Yang , linux-kernel@vger.kernel.org, Huacai Chen , Jian-Hong Pan , Takashi Iwai , Hui Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 10 May 2021 19:13:33 +0200, Elia Devito wrote: > > Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably > on similar models. > > 0x14 pin config override is required to enable all speakers and > alc285-speaker2-to-dac1 fixup to enable volume adjustment. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331 > Signed-off-by: Elia Devito Could you try to put the quirk entry in the PCI SSID order? thanks, Takashi > --- > sound/pci/hda/patch_realtek.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b4b71609dff1..be2a5cd2875d 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -6542,6 +6542,7 @@ enum { > ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST, > ALC295_FIXUP_ASUS_DACS, > ALC295_FIXUP_HP_OMEN, > + ALC285_FIXUP_HP_SPECTRE_X360, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED, > }, > + [ALC285_FIXUP_HP_SPECTRE_X360] = { > + .type = HDA_FIXUP_PINS, > + .v.pins = (const struct hda_pintbl[]) { > + { 0x14, 0x90170110 }, /* enable top speaker */ > + {} > + }, > + .chained = true, > + .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1, > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -8278,6 +8288,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x87f7, "HP Spectre x360 14", ALC245_FIXUP_HP_X360_AMP), > + SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), > SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x884c, "HP EliteBook 840 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED), > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > @@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { > {.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"}, > {.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"}, > {.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"}, > + {.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"}, > {} > }; > #define ALC225_STANDARD_PINS \ > -- > 2.31.1 >