From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 7/7] ALSA: hda/tegra: add driver flag for
	runtime PM
Date: Mon, 21 Jan 2019 22:31:25 +0100
Message-ID: <s5ho989y9xu.wl-tiwai@suse.de>
References: <1548092497-5459-1-git-send-email-spujar@nvidia.com>
 <1548092497-5459-8-git-send-email-spujar@nvidia.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id 070D92667E7
 for <alsa-devel@alsa-project.org>; Mon, 21 Jan 2019 22:31:25 +0100 (CET)
In-Reply-To: <1548092497-5459-8-git-send-email-spujar@nvidia.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Sameer Pujar <spujar@nvidia.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
List-Id: alsa-devel@alsa-project.org

On Mon, 21 Jan 2019 18:41:37 +0100,
Sameer Pujar wrote:
> 
> AZX_DCAPS_PM_RUNTIME flag is added to indicate support for runtime PM.
> azx_has_pm_runtime() can be called to check if above is enabled. The
> flag is put under CONFIG_PM check.
> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
> Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>

This can be more simply done in hda_controller.h.  Namely, a change
like:

--- a/sound/pci/hda/hda_controller.h
+++ b/sound/pci/hda/hda_controller.h
@@ -49,7 +49,11 @@
 #define AZX_DCAPS_4K_BDLE_BOUNDARY (1 << 23)	/* BDLE in 4k boundary */
 /* 24 unused */
 #define AZX_DCAPS_COUNT_LPIB_DELAY  (1 << 25)	/* Take LPIB as delay */
+#ifdef CONFIG_PM
 #define AZX_DCAPS_PM_RUNTIME	(1 << 26)	/* runtime PM support */
+#else
+#define AZX_DCAPS_PM_RUNTIME	0		/* N/A */
+#endif
 /* 27 unused */
 #define AZX_DCAPS_CORBRP_SELF_CLEAR (1 << 28)	/* CORBRP clears itself after reset */
 #define AZX_DCAPS_NO_MSI64      (1 << 29)	/* Stick to 32-bit MSIs */


thanks,

Takashi